tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2230) AjaxFormLoop Add Row Broken
Date Sun, 22 Jun 2014 21:43:25 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040262#comment-14040262
] 

Hudson commented on TAP5-2230:
------------------------------

FAILURE: Integrated in tapestry-trunk-freestyle #1248 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1248/])
Some adjustments for TAP5-2230 (thiagohp: rev fbd7d031e2753411c540dd00d2c3c8d8753dd89c)
* tapestry-json/src/main/java/org/apache/tapestry5/json/JSONObject.java
* tapestry-json/src/test/groovy/json/specs/JSONArraySpec.groovy
* tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java


> AjaxFormLoop Add Row Broken
> ---------------------------
>
>                 Key: TAP5-2230
>                 URL: https://issues.apache.org/jira/browse/TAP5-2230
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.4
>            Reporter: Peter H
>            Assignee: Thiago H. de Paula Figueiredo
>              Labels: month-of-tapestry
>             Fix For: 5.4
>
>
> We're using 5.4.26 but have seen this in 5.4.25 too so assume it's a fairly long-standing
issue in the alphas.
> Use ajaxformloop, click add row, check your browser's console, see client-side error
as follows:
> Uncaught TypeError: Object <DIV class="trowandloadsmoremarkupbesidesthatistheentirecontentsofyourajaxformloop</DIV>
has no method 'trigger' 
> Look at ajaxformloop.js, see lines 42-44.
> newElement = "<" + insertionPoint.element.tagName + " class=\"" + insertionPoint.element.className
+ "\"\n  data-container-type=\"" + FRAGMENT_TYPE + "\">\n  " + content + "\n  </" +
insertionPoint.element.tagName + ">";
>           insertionPoint.insertBefore(newElement);
>           return newElement.trigger(events.zone.didUpdate);
> Change them to the following:
> {code}
> newElement = "<" + insertionPoint.element.tagName + " class=\"" + insertionPoint.element.className
+ "\"\n  data-container-type=\"" + FRAGMENT_TYPE + "\">\n  " + content + "\n  </" +
insertionPoint.element.tagName + ">";
> newElement = insertionPoint.insertBefore(newElement);
>           return newElement.trigger(events.zone.didUpdate);
> {code}
> Note the missing assignment of the newElement after its insertion. We are calling trigger
on a string. And all is fixed. :D



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message