tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thiago H. de Paula Figueiredo (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (TAP5-2012) Make multiple same name service decoration methods error message better
Date Fri, 06 Jun 2014 14:54:02 GMT

     [ https://issues.apache.org/jira/browse/TAP5-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Thiago H. de Paula Figueiredo closed TAP5-2012.

       Resolution: Fixed
    Fix Version/s: 5.4

Fixed by not allowing two different decorators methods with the same name in different module
classes and throwing an exception describing the problem and suggesting a fix.

> Make multiple same name service decoration methods error message better
> -----------------------------------------------------------------------
>                 Key: TAP5-2012
>                 URL: https://issues.apache.org/jira/browse/TAP5-2012
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>            Reporter: Ville Virtanen
>            Assignee: Thiago H. de Paula Figueiredo
>              Labels: month-of-tapestry
>             Fix For: 5.4
> If one has many decoration methods that are named exactly the same way the other decoration
is silently dropped with log warn "Could not add object with duplicate id 'ServiceInterfaceName'.
The duplicate object has been ignored."
> This error message could be greatly improved if it would clearly state that there are
multiple decoration methods that have the same name, and additionally it would be nice to
provide the list of modules that do have the problematic methods. 
> It could further be improved by having the possible fix in the message, that is to use
Match annotation and to match the service interface and to change the name of the method.
> It would also be nice touch to mention in the log message which method won this time
as it seems that is somewhat random, and would be useful later when diagnosing problems.

This message was sent by Atlassian JIRA

View raw message