tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2184) Select component fails validation due to type mismatch when using model generated from String
Date Mon, 16 Sep 2013 18:00:55 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768553#comment-13768553
] 

Hudson commented on TAP5-2184:
------------------------------

SUCCESS: Integrated in tapestry-trunk-freestyle #1161 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1161/])
TAP5-2184: Select component fails validation due to type mismatch when using  model generated
from String (hlship: rev 66fc5f0c6310dfb0a94880f36cfd258d4174ef3e)
* tapestry-core/src/main/java/org/apache/tapestry5/internal/TapestryInternalUtils.java
* tapestry-core/src/test/java/org/apache/tapestry5/corelib/components/SelectTest.java
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Select.java
* tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java

                
> Select component fails validation due to type mismatch when using  model generated from
String
> ----------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2184
>                 URL: https://issues.apache.org/jira/browse/TAP5-2184
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.4
>
>
> A recent change to the Select component enables, by default, the validation of a submitted
value to a Select against its SelectModel.
> This works fine in most cases ... however, when the SelectModel is created from a String,
the values are also Strings even if the property edited by the Select is a non-String type
(relying, again, on TypeCoercer to convert).  This causes a failure in the typical case where
the string is a list of number, say "1,5,10"; the  provided SelectModel provides the values
as strings, e.g., "10", which does match against even a valid submitted value, since the ValueEncoder
will have converted the value to a number before the search.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message