tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lenny Primak <lpri...@hope.nyc.ny.us>
Subject Re: [jira] [Created] (TAP5-2187) CSS relative URL rewriting isn't lenient enough
Date Mon, 23 Sep 2013 19:34:31 GMT

On Sep 23, 2013, at 3:26 PM, Thiago H de Paula Figueiredo wrote:

> On Mon, 23 Sep 2013 16:19:14 -0300, Lenny Primak <lprimak@hope.nyc.ny.us> wrote:
> 
>> Yes it does.  It says that .png file was not found,
>> but the exception is while loading the .css file.
> 
> Weird. It does sound like a bug.
> 
>> There are lots of .css files that have errors / missing files in them, not under
my control.
>> If I had to write a RequestFilter for each and every one of them, it would be nightmare.
> 
> If there was some pattern, you could use the same RequestFilter for all them.

The issue is I don't know which one is valid or not, etc.  This isn't the way to solve this
(see below)
> 
>> The new 5.4 CSS URL rewriting mechanism should just leave the links to unknown assets
alone,
>> that's what I mean by 'ignoring' it.  Just like the browser does when it loads CSS
files.
> 
> You imply the CSS URL rewriting checks whether referenced files exist or not. Have you
checked this is correct? I'm not sure and I haven't checked yet.

Yes.  Now you understand the core issue.  It checks all the references (and tries to rewrite
them with checksums)
which is correct.  If a reference doesn't exist, the whole CSS file gets a 500 server error
/ exception.
This is the issue, because now the whole CSS file is invalid when Tapestry should just ignore
missing references and leave them as they are

>> 
>> On Sep 23, 2013, at 3:13 PM, Thiago H de Paula Figueiredo wrote:
>> 
>>> Hi, Lenny!
>>> 
>>> Have you checked if Tapestry throws any exceptions? After all, this is an HTTP
500, which means internal error.
>>> 
>>> I don't know why you mean by "ignore". Did you mean raise a 404 error?
>>> 
>>> A workaround would be to add a RequestFilter or Dispatcher that checks for that
non-existent URL and do something about it.
>>> 
>>> On Sun, 22 Sep 2013 22:41:02 -0300, Lenny Primak (JIRA) <jira@apache.org>
wrote:
>>> 
>>>> Lenny Primak created TAP5-2187:
>>>> ----------------------------------
>>>> 
>>>>            Summary: CSS relative URL rewriting isn't lenient enough
>>>>                Key: TAP5-2187
>>>>                URL: https://issues.apache.org/jira/browse/TAP5-2187
>>>>            Project: Tapestry 5
>>>>         Issue Type: Bug
>>>>         Components: tapestry-core
>>>>   Affects Versions: 5.4
>>>>           Reporter: Lenny Primak
>>>> 
>>>> 
>>>> I am trying to integrate an existing GWT framework as tapestry components.
>>>> One of the .css files its trying to load references an non-existent .png
file.
>>>> Instead of just ignoring it, Tapestry produces a 500 error loading the .css
file,
>>>> which I don't believe there is a workaround for.
>>>> 
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> If you think it was sent incorrectly, please contact your JIRA administrators
>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>> 
>>> 
>>> --
>>> Thiago H. de Paula Figueiredo
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>> 
> 
> 
> -- 
> Thiago H. de Paula Figueiredo
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message