tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1358) GridPager links need to send page's request parameters
Date Mon, 29 Jul 2013 16:23:50 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722587#comment-13722587

Howard M. Lewis Ship commented on TAP5-1358:

Thanks for the confirmation!
> GridPager links need to send page's request parameters
> ------------------------------------------------------
>                 Key: TAP5-1358
>                 URL: https://issues.apache.org/jira/browse/TAP5-1358
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions:
>            Reporter: Geoff Callender
>              Labels: bulk-close-candidate
> GridPager uses EventLinks, but EventLink has a problem: even though it DOES send the
page's activation context (which is good), it DOESN'T send the page's request parameters (which
is bad)!  
> Does this happen in 5.2 too?
> This is a real problem since I like to put search/filter criteria into request parameters
and not the context. The problem is that when I click on a GridPager link I lose the search/filter
criteria. Why do I use request parameters for search/filter criteria? Because it is arguably
more RESTful. See 
>     http://jumpstart.doublenegative.com.au/jumpstart/examples/state/passingdatabetweenpages1
>     http://blpsilva.wordpress.com/2008/04/05/query-strings-in-restful-web-services/
> Example
> A page has enterable search criteria fields (name, department, status). 
> Type in a name and submit the page. We redisplay with the Grid populated and more than
one grid page.
> If the page puts the search criteria in the activation context then the GridPager's link
to page 2 looks fine - like this...
>         http://localhost/myapp/things/index.grid.pager/2?t:ac=jack/$N/ACTIVE
> ...however if the page puts the search criteria in the request parameters, then the GridPager's
link to page 2 looks inadequate - like this...
>         https://localhost/myapp/things/index.grid.pager/2
> ...but to prevent losing the request parameters it should be like this...
>         https://localhost/myapp/things/index.grid.pager/2?name=jack&status=ACTIVE
> I wasted a lot of time figuring out this was what was going wrong, even though I could
see this what was happening, because I was refusing to believe that request parameters weren't
getting equal treatment in this situation!

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message