tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hls...@apache.org
Subject git commit: TAP5-1887: Client-side JavaScript error if console.info/debug/... is available but not a function
Date Sat, 18 Aug 2012 00:33:11 GMT
Updated Branches:
  refs/heads/5.3 282773de8 -> 4fbe60b8c


TAP5-1887: Client-side JavaScript error if console.info/debug/... is available but not a function


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4fbe60b8
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4fbe60b8
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4fbe60b8

Branch: refs/heads/5.3
Commit: 4fbe60b8c497dc3f6fe94804d74a3857f83b2a22
Parents: 282773d
Author: Howard M. Lewis Ship <hlship@apache.org>
Authored: Fri Aug 17 17:32:54 2012 -0700
Committer: Howard M. Lewis Ship <hlship@apache.org>
Committed: Fri Aug 17 17:32:54 2012 -0700

----------------------------------------------------------------------
 .../resources/org/apache/tapestry5/t5-console.js   |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4fbe60b8/tapestry-core/src/main/resources/org/apache/tapestry5/t5-console.js
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/resources/org/apache/tapestry5/t5-console.js b/tapestry-core/src/main/resources/org/apache/tapestry5/t5-console.js
index df4c5c4..f4db7c5 100644
--- a/tapestry-core/src/main/resources/org/apache/tapestry5/t5-console.js
+++ b/tapestry-core/src/main/resources/org/apache/tapestry5/t5-console.js
@@ -1,4 +1,4 @@
-// Copyright 2011 The Apache Software Foundation
+// Copyright 2011, 2012 The Apache Software Foundation
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -57,8 +57,8 @@ T5.define("console", function() {
             display(className, message);
 
             // consolefn may be null when there is no native console, in which case
-            // do nothing more
-            consolefn && consolefn.call(console, message);
+            // do nothing more. It may be a non-function under IE.
+            T5._.isFunction(consolefn) && consolefn.call(console, message);
         }
     }
 
@@ -71,4 +71,4 @@ T5.define("console", function() {
         warn : level("t-warn", nativeConsole.warn),
         error : level("t-err", nativeConsole.error)
     };
-});
\ No newline at end of file
+});


Mime
View raw message