tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAP5-1481) ComponentPageElementImpl to throw a special exception when a component cannot be found by id
Date Wed, 19 Oct 2011 17:27:10 GMT

     [ https://issues.apache.org/jira/browse/TAP5-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Howard M. Lewis Ship updated TAP5-1481:
---------------------------------------


Seems to me that a better solution for this is more general:  in production mode, when URLs
arrive that can not be processed (such as referencing an unknown page or component id), the
request should not be handled by Tapestry, resulting in a standard 404 from the servlet container.

That's a big change, and should be visited in 5.4.
                
> ComponentPageElementImpl to throw a special exception when a component cannot be found
by id
> --------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1481
>                 URL: https://issues.apache.org/jira/browse/TAP5-1481
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.4, 5.1.0.5
>            Reporter: Anton Litvinenko
>
> when an embedded component cannot be found by id, then ComponentPageElementImpl throws
a TapestryException at line 841 for 5.1.0.5 (UnknownValueException for 5.2.4).
> I suggest throwing a special kind of exception in such case (e.g. EmbeddedComponentNotFoundException
or ComponentNotFoundException), so that application would be able to handle such cases separately
(e.g. by serving a 404 error page).
> Particular use-case: google indexing bot cached a tapestry page and tries indexing links
that are included on this page. If links are actionlinks, then they include id of the component.
When one changes the id of the component (or renames the component), then the "old" link doesn't
work anymore as it contains old id of the component -> google indexing bot is served with
Tapestry error page (which is a typical page). Instead, it makes sense to send a 404 error
as result and let google bot know that there is no such resource anymore. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message