tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Gidley <...@gidley.co.uk>
Subject Re: TAP5-769 and interface changes
Date Thu, 06 Aug 2009 07:05:32 GMT
Hi,
Is there any chance of a commiter reviewing these patches -
https://issues.apache.org/jira/browse/TAP5-769? I am happy to modify them if
you feel they need adjustment!

<https://issues.apache.org/jira/browse/TAP5-769>
Ben Gidley

www.gidley.co.uk
ben@gidley.co.uk


On Fri, Jul 17, 2009 at 12:45 PM, Ben Gidley <ben@gidley.co.uk> wrote:

> I have posted a patch for https://issues.apache.org/jira/browse/TAP5-769 that
> resolves the issue. It allows javascript to be grouped into combined files
> thus allowing you to share common javascript between pages.
> An obvious enhancement would be to expose this to RenderSupport (at the
> moment I have only made 'internal' changes) - however I was unsure of how
> the interface should be changed. Following the thread recently -
> RenderSupport is mostly an interface you would expect people to use not
> implement, but it is not impossible someone has implemented it or wrapped
> it.
>
> So presuming a RenderSupport.addGroupedScriptLink(String group, String...
> scriptURLs) was desirable should I create a RenderSupport2 or just add it to
> RenderSupport?
>
> As an aside what is the preferred way of telling commiters about patches -
> do you want an email to this list as well as adding it to JIRA?
>
> Ben Gidley
>
> www.gidley.co.uk
> ben@gidley.co.uk
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message