tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Zeigler <robe...@scazdl.org>
Subject Re: stax template parser and column
Date Thu, 16 Jul 2009 18:33:03 GMT
That's what I was thinking; more often than not, the column number is  
misleading.
I'll update the tests.

Robert

On Jul 16, 2009, at 7/1612:44 PM , Howard Lewis Ship wrote:

> Most XML parsers don't do a very good job of reporting the column
> number; usually it seems to be the end of the element tag, not the
> start. The amount of work needed to figure out the actual position
> isn't all that worthwhile, and identifying the line number (and
> highlighting it in the exception report page) seems to be more than
> enough.
>
> On Wed, Jul 15, 2009 at 11:28 AM, Robert Zeigler<robertz@scazdl.org>  
> wrote:
>> In StaxTemplateParser.getLocation, is the call to the  
>> LocationImpl(Resource,
>> int) constructor, as opposed to the LocationImpl(Resource, int, int)
>> constructor, deliberate (ie: are we no longer bothering with  
>> tracking the
>> column information)? I ask only because there are integration tests  
>> that
>> test for the presence of column information.  These tests were  
>> passing
>> before only because of an apparent bug in "assertTextPresent"  
>> whereby only
>> the first element of the varag parameter was examined (a return  
>> statement
>> should have been continue).
>> I just need to know whether to fix the tests or the code.
>>
>> Robert
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>>
>
>
>
> -- 
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
> Director of Open Source Technology at Formos
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Mime
View raw message