Return-Path: Delivered-To: apmail-tapestry-dev-archive@www.apache.org Received: (qmail 68154 invoked from network); 16 Nov 2008 18:12:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Nov 2008 18:12:03 -0000 Received: (qmail 99404 invoked by uid 500); 16 Nov 2008 18:12:11 -0000 Delivered-To: apmail-tapestry-dev-archive@tapestry.apache.org Received: (qmail 99111 invoked by uid 500); 16 Nov 2008 18:12:11 -0000 Mailing-List: contact dev-help@tapestry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tapestry development" Delivered-To: mailing list dev@tapestry.apache.org Received: (qmail 99096 invoked by uid 99); 16 Nov 2008 18:12:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Nov 2008 10:12:10 -0800 X-ASF-Spam-Status: No, hits=1.7 required=10.0 tests=SPF_PASS,WEIRD_PORT,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of hlship@gmail.com designates 74.125.92.24 as permitted sender) Received: from [74.125.92.24] (HELO qw-out-2122.google.com) (74.125.92.24) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Nov 2008 18:10:47 +0000 Received: by qw-out-2122.google.com with SMTP id 8so1026726qwh.59 for ; Sun, 16 Nov 2008 10:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=pWhaQkf3TKiRROGbPqW5jqASzzYw6EHHMaKM+ekDu18=; b=SYQwUr0/0ZKiLhi/tIqJL1GGKlJENCS3Tif7RmPcDA02rAn1+Dy15ir4cXieh5AzDm Bm69bc3Fc2UBjsc10+jaVCeUT2uMIXJwlzpL5AxwKs9kJnF+A+scHDmJQJ9yO/CYxyvT 37na7ABYd6bKsbuEwQ7FUca8Dt5wBLFbM1cQI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=PN7lXZ3G9pvMUyD6bgYCzslYOAnOBqKiMeNpBX07P6oYVZi+e3yaD3hAGHrTcf5FiR aHkRvBFKnbAyUgP8Mdc2bpn4wrmyBPtWusrDv+DUyLYjc+RMywComOffitXalE83PYio 5insNrK6zapq5LW9PBsRNVye+4ScdMOease+g= Received: by 10.214.147.21 with SMTP id u21mr2065648qad.16.1226859090464; Sun, 16 Nov 2008 10:11:30 -0800 (PST) Received: by 10.215.67.20 with HTTP; Sun, 16 Nov 2008 10:11:30 -0800 (PST) Message-ID: Date: Sun, 16 Nov 2008 10:11:30 -0800 From: "Howard Lewis Ship" To: "Tapestry development" Subject: Re: [VOTE] Release 5.0.16 -- Release Candidate In-Reply-To: <87E29021-3F5F-4CAE-9775-8F8EE6D319A3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1226627384414-1496710.post@n2.nabble.com> <4623F6F0-1BDA-4147-9785-54DBAC2B695F@gmail.com> <36CA909B-749C-43B1-B2F4-E719CC86162E@mac.com> <87E29021-3F5F-4CAE-9775-8F8EE6D319A3@gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org I think this is the problem: https://issues.apache.org/jira/browse/TAP5-361 The warnings used to be hidden in the FireBug console. On Sun, Nov 16, 2008 at 3:10 AM, Geoff Callender wrote: > +1 (non-binding) > > Thanks for the explanation, Howard. One thing, though - why didn't my > custom validator have the same problem? > > http://localhost:8180/jumpstart/examples/input/creatingvalidators1 > > or if that site is not up then: > > http://localhost:8080/jumpstart/examples/input/creatingvalidators1 > > Cheers, > Geoff > > On 16/11/2008, at 4:24 PM, Howard Lewis Ship wrote: > >> Don't invoke FormSupport.addValidation() unless you have client-side >> validation for your validator. The name of the method, and >> documentation, could be better. >> >> On Sat, Nov 15, 2008 at 6:03 PM, Geoff Callender >> wrote: >>> >>> I haven't created client-side validation for this translator, but that >>> hasn't previously been a problem. How do I stop it being a problem now? >>> >>> On 16/11/2008, at 12:59 PM, Howard Lewis Ship wrote: >>> >>>> Looks like user error to me ... I only see the base set of JavaScript >>>> files being loaded; where's you @IncludeJavaScriptLibrary annotation? >>>> You can't expect the code to exist if its never been loaded! >>>> >>>> On Sat, Nov 15, 2008 at 4:45 PM, Geoff Callender >>>> wrote: >>>>> >>>>> That's fixed the email validator. But what must I do to fix my custom >>>>> translator? >>>>> You can see the problem in action here: >>>>> >>>>> >>>>> >>>>> >>>>> http://jumpstart.doublenegative.com.au:8180/jumpstart/examples/input/creatingtranslators1 >>>>> >>>>> or if that site is not up try here: >>>>> >>>>> >>>>> >>>>> >>>>> http://jumpstart.doublenegative.com.au:8080/jumpstart/examples/input/creatingtranslators1 >>>>> >>>>> Cheers, >>>>> Geoff >>>>> >>>>> On 16/11/2008, at 8:09 AM, Howard Lewis Ship wrote: >>>>> >>>>>> OK, I've updated the maven artifacts, the site, and the downloads to >>>>>> incude the TAP5-359 fix (the client-side warning about email >>>>>> validation). >>>>>> >>>>>> On Sat, Nov 15, 2008 at 9:56 AM, Howard Lewis Ship >>>>>> wrote: >>>>>>> >>>>>>> Ok, I'm producing a new 5.0.16 build now. >>>>>>> >>>>>>> >>>>>>> On Sat, Nov 15, 2008 at 9:12 AM, Howard Lewis Ship >>>>>>> wrote: >>>>>>>> >>>>>>>> You are correct, looking at the code, there's an errant call to >>>>>>>> setup >>>>>>>> client-side validation, even though there is no client-side >>>>>>>> validator. >>>>>>>> >>>>>>>> Since the release is not yet public, I'll correct that and build a >>>>>>>> new >>>>>>>> 5.0.16. >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Nov 13, 2008 at 5:49 PM, Geoff Callender >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> -1 (non-binding) >>>>>>>>> I must change my vote until someone confirms there is not a >>>>>>>>> validators >>>>>>>>> problem. >>>>>>>>> >>>>>>>>> Can someone please try an input field with a required, email >>>>>>>>> validator >>>>>>>>> and >>>>>>>>> client-side validation turned on and confirm whether they, too, get >>>>>>>>> a >>>>>>>>> red >>>>>>>>> error overlaying the top of the page saying something like >>>>>>>>> "Function >>>>>>>>> Tapestry.Validator.email() does not exist for field >>>>>>>>> 'myEmailAddress'." >>>>>>>>> >>>>>>>>> It's so distracting and clearly unsuitable for production. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Geoff >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Geoff Callender-3 wrote: >>>>>>>>>> >>>>>>>>>> +0 (non-binding) >>>>>>>>>> >>>>>>>>>> It's passed all of my tests but I'm seeing red messages at the top >>>>>>>>>> of >>>>>>>>>> some screens, eg. >>>>>>>>>> >>>>>>>>>> Function Tapestry.Validator.yesno() does not exist for field >>>>>>>>>> 'newToTapestry'. >>>>>>>>>> >>>>>>>>>> I'm seeing it on the following page after upgrade to 5.0.16: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> http://jumpstart.doublenegative.com.au:8080/jumpstart/examples/input/creatingtranslators1 >>>>>>>>>> >>>>>>>>>> Does this just require a simple code change at my end? >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Geoff >>>>>>>>>> >>>>>>>>>> On 11/11/2008, at 7:46 PM, Ted Steen wrote: >>>>>>>>>> >>>>>>>>>>> Ted Steen: +1 (non-binding) >>>>>>>>>>> >>>>>>>>>>> 2008/11/11 David Solis : >>>>>>>>>>>> >>>>>>>>>>>> David Solis: +1 >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Nov 10, 2008 at 6:55 PM, Howard Lewis Ship >>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> I've created and uploaded a release of Tapestry 5.0.16, ready >>>>>>>>>>>>> to >>>>>>>>>>>>> be voted upon. >>>>>>>>>>>>> >>>>>>>>>>>>> It's been two months since 5.0.15, and I've fixed over 80 bugs. >>>>>>>>>>>>> I >>>>>>>>>>>>> think Tapestry 5.0.16 is of release candidate quality and it >>>>>>>>>>>>> should be >>>>>>>>>>>>> made publically available to verify its readiness to be the GA >>>>>>>>>>>>> release >>>>>>>>>>>>> as well. >>>>>>>>>>>>> >>>>>>>>>>>>> The files are uploaded to: >>>>>>>>>>>>> >>>>>>>>>>>>> http://people.apache.org/~hlship/tapestry-releases/ >>>>>>>>>>>>> >>>>>>>>>>>>> and a Maven repository: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> http://people.apache.org/~hlship/tapestry-ibiblio-rsynch-repository/ >>>>>>>>>>>>> >>>>>>>>>>>>> Please examine these files to determine if a new preview >>>>>>>>>>>>> release, >>>>>>>>>>>>> 5.0.16, is ready, and of release candidate quality. >>>>>>>>>>>>> >>>>>>>>>>>>> I've also created a 5.0.16 tag in Subversion: >>>>>>>>>>>>> >>>>>>>>>>>>> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/ >>>>>>>>>>>>> 5.0.16/ >>>>>>>>>>>>> >>>>>>>>>>>>> On a successful vote, I'll move the files from these >>>>>>>>>>>>> directories >>>>>>>>>>>>> to >>>>>>>>>>>>> the proper distribution directories. >>>>>>>>>>>>> >>>>>>>>>>>>> Vote will run for three days; on success I'll move the voted >>>>>>>>>>>>> artifacts >>>>>>>>>>>>> into place and send out appropriate notifications. >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Howard M. Lewis Ship >>>>>>>>>>>>> >>>>>>>>>>>>> Creator Apache Tapestry and Apache HiveMind >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>>>>>>>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>>>>>>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>>>>>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>>>>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> View this message in context: >>>>>>>>> >>>>>>>>> >>>>>>>>> http://n2.nabble.com/-VOTE--Release-5.0.16----Release-Candidate-tp1483148p1496710.html >>>>>>>>> Sent from the Tapestry Developers mailing list archive at >>>>>>>>> Nabble.com. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> --------------------------------------------------------------------- >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>>>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Howard M. Lewis Ship >>>>>>>> >>>>>>>> Creator Apache Tapestry and Apache HiveMind >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Howard M. Lewis Ship >>>>>>> >>>>>>> Creator Apache Tapestry and Apache HiveMind >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Howard M. Lewis Ship >>>>>> >>>>>> Creator Apache Tapestry and Apache HiveMind >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Howard M. Lewis Ship >>>> >>>> Creator Apache Tapestry and Apache HiveMind >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>>> For additional commands, e-mail: dev-help@tapestry.apache.org >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >>> For additional commands, e-mail: dev-help@tapestry.apache.org >>> >>> >> >> >> >> -- >> Howard M. Lewis Ship >> >> Creator Apache Tapestry and Apache HiveMind >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org >> For additional commands, e-mail: dev-help@tapestry.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org > For additional commands, e-mail: dev-help@tapestry.apache.org > > -- Howard M. Lewis Ship Creator Apache Tapestry and Apache HiveMind --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org For additional commands, e-mail: dev-help@tapestry.apache.org