Return-Path: 
 <tapestry-dev-return-7398-apmail-jakarta-tapestry-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tapestry-dev-archive@www.apache.org
Received: (qmail 49241 invoked from network); 1 Aug 2005 11:26:15 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 1 Aug 2005 11:26:15 -0000
Received: (qmail 13965 invoked by uid 500); 1 Aug 2005 11:26:12 -0000
Delivered-To: apmail-jakarta-tapestry-dev-archive@jakarta.apache.org
Received: (qmail 13945 invoked by uid 500); 1 Aug 2005 11:26:12 -0000
Mailing-List: contact tapestry-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:tapestry-dev-unsubscribe@jakarta.apache.org>
List-Help: <mailto:tapestry-dev-help@jakarta.apache.org>
List-Post: <mailto:tapestry-dev@jakarta.apache.org>
List-Id: "Tapestry development" <tapestry-dev.jakarta.apache.org>
Reply-To: "Tapestry development" <tapestry-dev@jakarta.apache.org>
Delivered-To: mailing list tapestry-dev@jakarta.apache.org
Received: (qmail 13924 invoked by uid 99); 1 Aug 2005 11:26:10 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=SPF_FAIL
X-Spam-Check-By: apache.org
Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Aug 2005 04:25:54 -0700
Received: from ajax.apache.org (ajax.apache.org [127.0.0.1])
	by ajax.apache.org (Postfix) with ESMTP id 0F57AE4
	for <tapestry-dev@jakarta.apache.org>; Mon,  1 Aug 2005 13:25:51 +0200 (CEST)
Message-ID: <1281385883.1122895551061.JavaMail.jira@ajax.apache.org>
Date: Mon, 1 Aug 2005 13:25:51 +0200 (CEST)
From: "Jonas Maurus (JIRA)" <tapestry-dev@jakarta.apache.org>
To: tapestry-dev@jakarta.apache.org
Subject: [jira] Updated: (TAPESTRY-517) Using a FieldLabel component after the
 decorated form component causes the FieldLabel's id attribute to be wrong
In-Reply-To: <1349761559.1122856355167.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

     [ http://issues.apache.org/jira/browse/TAPESTRY-517?page=all ]

Jonas Maurus updated TAPESTRY-517:
----------------------------------

    Attachment: AbstractFormComponent.clientid_fix_2.diff

This patch fixes all issues (including the runaway formids), but doesn't fix the underlying design issues. I've started a discussion on the developer mailing list (http://news.gmane.org/gmane.comp.jakarta.tapestry.devel) on this bug to create a roadmap.

> Using a FieldLabel component after the decorated form component causes the FieldLabel's id attribute to be wrong
> ----------------------------------------------------------------------------------------------------------------
>
>          Key: TAPESTRY-517
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-517
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>     Reporter: Jonas Maurus
>  Attachments: AbstractFormComponent.clientid_fix.diff, AbstractFormComponent.clientid_fix_2.diff
>
> Quoting from TAPESTRY-409:
> <!-- page definition -->
>   <component id="bookkeeperRCB" type="Checkbox">
>     <binding name="selected" value="hasBookkeeperRole" />
>   </component>
>   
>   <component id="adminRCB" type="Checkbox">
>     <binding name="selected" value="hasAdministratorRole" />
>   </component>
> <!-- page template -->
> <tr>
>   <td><input jwcid="bookkeeperRCB" type="checkbox" value="Y" /></td>
>   <td><label jwcid="@FieldLabel" for="bookkeeper"
>             field="ognl:components.bookkeeperRCB" displayName="message:form.roles.bookkeeper">Bookkeeper</label></td>
> </tr>
> <tr>
>   <td><input jwcid="adminRCB" type="checkbox" value="Y" /></td>
>   <td><label jwcid="@FieldLabel" for="admin"
>            field="ognl:components.adminRCB" displayName="message:form.roles.administrator">Administrator</label></td>
> </tr>
> yields:
> <tr>
>   <td><input type="checkbox" name="bookkeeperRCB" id="bookkeeperRCB" value="Y"/></td>
>   <td><label for="bookkeeperRCB$0">Bookkeeper</label></td>
> </tr>
> <tr>
>   <td><input type="checkbox" name="adminRCB" checked="checked" id="adminRCB" value="Y"/></td>
>   <td><label for="adminRCB$0">Administrator</label></td>
> </tr>
> as you can see the generated fieldnames ("bookkeeperRCB$0"...) are wrong. This always results in a stale-link exception.
> I tracked down the bug: FieldLabel calls prerenderField() which in turn causes an uniqueId to be allocated in AbstractFormComponent.renderIdAttribute. Everything works out when the FieldLabel precedes the form component it decorates. If it comes after the form component, IRequestCycle.getUniqueId() will already have stored an id for the component and return a new one.
> I'm not quite sure about the mechanics described above, as I don't fully understand FormSupportImpl yet, perhaps someone else can shed light on this.
> However, the allocated client id wasn't cached properly in AbstractFormComponent.renderIdAttribute. I'll attach a patch as soon as I've saved this bug report.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org