Return-Path: 
 <tapestry-dev-return-2151-apmail-jakarta-tapestry-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tapestry-dev-archive@www.apache.org
Received: (qmail 25059 invoked from network); 5 Dec 2003 01:18:14 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 5 Dec 2003 01:18:14 -0000
Received: (qmail 48667 invoked by uid 500); 5 Dec 2003 01:17:58 -0000
Delivered-To: apmail-jakarta-tapestry-dev-archive@jakarta.apache.org
Received: (qmail 48643 invoked by uid 500); 5 Dec 2003 01:17:58 -0000
Mailing-List: contact tapestry-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:tapestry-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:tapestry-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:tapestry-dev-help@jakarta.apache.org>
List-Post: <mailto:tapestry-dev@jakarta.apache.org>
List-Id: "Tapestry development" <tapestry-dev.jakarta.apache.org>
Reply-To: "Tapestry development" <tapestry-dev@jakarta.apache.org>
Delivered-To: mailing list tapestry-dev@jakarta.apache.org
Received: (qmail 48615 invoked from network); 5 Dec 2003 01:17:57 -0000
Received: from unknown (HELO mail.iinet.net.au) (203.59.3.38)
  by daedalus.apache.org with SMTP; 5 Dec 2003 01:17:57 -0000
Received: (qmail 31112 invoked from network); 5 Dec 2003 00:56:52 -0000
Received: from unknown (HELO mouse.iinet.net.au) (203.217.42.173)
  by mail.iinet.net.au with SMTP; 5 Dec 2003 00:56:51 -0000
Message-Id: <6.0.0.22.0.20031205115413.032b5398@mail.iinet.net.au>
X-Sender: gstamp@mail.iinet.net.au
X-Mailer: QUALCOMM Windows Eudora Version 6.0.0.22
Date: Fri, 05 Dec 2003 11:56:44 +1100
To: tapestry-dev@jakarta.apache.org
From: Glen Stampoultzis <gstamp@iinet.net.au>
Subject: [PATCH] Some build improvements
Mime-Version: 1.0
Content-Type: multipart/mixed;
	boundary="=====================_10363781==_"
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

--=====================_10363781==_
Content-Type: text/plain; charset="us-ascii"; format=flowed


I've attached a small patch to provide greater error reporting when you 
haven't defined certain things in build.properties.

Regards,


Glen Stampoultzis
gstamp@iinet.net.au
http://members.iinet.net.au/~gstamp/glen/

--=====================_10363781==_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: attachment; filename="diff.txt"

Index: contrib/build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-tapestry/contrib/build.xml,v
retrieving revision 1.19
diff -u -r1.19 build.xml
--- contrib/build.xml	21 May 2003 23:40:23 -0000	1.19
+++ contrib/build.xml	5 Dec 2003 00:52:56 -0000
@@ -23,7 +23,7 @@
 	<target name="clean">
 		<delete dir="${classes.dir}"/>
 	</target>
-	<target name="compile" depends="init"
+	<target name="compile" depends="init,check-j2ee-jar"
 		description="Compile all classes in the framework.">
 		<javac srcdir="${src.dir}" destdir="${classes.dir}" debug="on"
 			target="1.1">
@@ -41,4 +41,13 @@
 			</fileset>
 		</jar>
 	</target>
+    <target name="check-j2ee-jar">
+        <available property="exists.j2ee.jar.path" type="file" file="${j2ee.jar.path}" />
+		<fail unless="j2ee.jar.path"
+			message="Property j2ee.jar.path not specified in config/build.properties."
+			/>
+		<fail unless="exists.j2ee.jar.path"
+			message="JAR ${j2ee.jar.path} (j2ee.jar.path from config/build.properties) does not exist."
+			/>
+    </target>
 </project>
Index: framework/build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-tapestry/framework/build.xml,v
retrieving revision 1.25
diff -u -r1.25 build.xml
--- framework/build.xml	22 Jun 2003 02:56:14 -0000	1.25
+++ framework/build.xml	5 Dec 2003 00:52:57 -0000
@@ -18,7 +18,7 @@
 	<target name="clean">
 		<delete dir="${classes.dir}"/>
 	</target>
-	<target name="compile" depends="init"
+	<target name="compile" depends="init,check-servlet-jar"
 		description="Compile all classes in the framework.">
 		<javac srcdir="${src.dir}" destdir="${classes.dir}" debug="on"
 			target="1.1">
@@ -45,4 +45,13 @@
 		</jar>
 
 	</target>
+    <target name="check-servlet-jar">
+        <available property="exists.servlet.jar" type="file" file="${servlet.jar.path}" />
+		<fail unless="servlet.jar.path"
+			message="Property servlet.jar.path not specified in config/build.properties."
+			/>
+		<fail unless="exists.servlet.jar"
+			message="JAR ${servlet.jar.path} (servlet.jar.path from config/build.properties) does not exist."
+			/>
+    </target>
 </project>


--=====================_10363781==_
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
--=====================_10363781==_--