tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Vologzhanin (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TAP5-2564) Unwanted auto-boxing while annotation visiting
Date Mon, 19 Sep 2016 06:33:20 GMT
Eugene Vologzhanin created TAP5-2564:
----------------------------------------

             Summary: Unwanted auto-boxing while annotation visiting 
                 Key: TAP5-2564
                 URL: https://issues.apache.org/jira/browse/TAP5-2564
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-ioc
    Affects Versions: 5.3.8
            Reporter: Eugene Vologzhanin


class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be <b>java.lang.Boolean</b> not <b>boolean</b>.
In this case in rutime will be Caused by: java.lang.ClassCastException: java.lang.Boolean
cannot be cast to java.lang.Enum.

I fix with:
<pre>
                MemberValue memberValue;
                if (method.getReturnType().isPrimitive()) {
                    memberValue = Annotation.createMemberValue(this.constPool,
                            this.classPool.get(method.getReturnType().getName()));
                } else {
                    memberValue = Annotation.createMemberValue(this.constPool,
                            this.classPool.get(result.getClass().getName()));
                }

</pre>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message