Return-Path: X-Original-To: apmail-tapestry-commits-archive@minotaur.apache.org Delivered-To: apmail-tapestry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E98B118888 for ; Sat, 27 Jun 2015 04:22:04 +0000 (UTC) Received: (qmail 25296 invoked by uid 500); 27 Jun 2015 04:22:04 -0000 Delivered-To: apmail-tapestry-commits-archive@tapestry.apache.org Received: (qmail 25252 invoked by uid 500); 27 Jun 2015 04:22:04 -0000 Mailing-List: contact commits-help@tapestry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tapestry.apache.org Delivered-To: mailing list commits@tapestry.apache.org Received: (qmail 25242 invoked by uid 99); 27 Jun 2015 04:22:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jun 2015 04:22:04 +0000 Date: Sat, 27 Jun 2015 04:22:04 +0000 (UTC) From: "Hudson (JIRA)" To: commits@tapestry.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAP5-2029) Copy annotations from service implementation to proxy (was JPA annotations expose implementation details in service interfaces) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TAP5-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603964#comment-14603964 ] Hudson commented on TAP5-2029: ------------------------------ ABORTED: Integrated in tapestry-trunk-freestyle #1450 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1450/]) TAP5-2029 : fixing the handling of annotations placed both on interface and implementation of a service (thiagohp: rev b65ad362e1d0bacf2f243255ee9b1e45db1c76c0) * plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/ClassNode.java * tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/NonAnnotatedServiceInterface.java * plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/AnnotationNode.java * plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java * tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/NonAnnotatedServiceInterfaceImpl.java * tapestry-ioc/src/test/groovy/ioc/specs/MethodInvocationGetAnnotationSpec.groovy > Copy annotations from service implementation to proxy (was JPA annotations expose implementation details in service interfaces) > ------------------------------------------------------------------------------------------------------------------------------- > > Key: TAP5-2029 > URL: https://issues.apache.org/jira/browse/TAP5-2029 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-ioc > Affects Versions: 5.3.6, 5.4 > Reporter: John Coleman > Assignee: Thiago H. de Paula Figueiredo > Priority: Minor > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-TAP5-2029-Test-case-involving-generic-interface.patch > > > The commit after and persistence context annotations are required on the service interface definition thereby exposing internal implementation details (see below example from docs). Details of implementation should be hidden at the interface level, both these annotations break the rule. > Perhaps this code could appear in the Impl classes, or be provided in configuration somehow? > public interface UserDAO { > @CommitAfter > @PersistenceContext(unitName = "DemoUnit") > void add(User user); -- This message was sent by Atlassian JIRA (v6.3.4#6332)