tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thiago H. de Paula Figueiredo (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAP5-2185) Problem with the asset checksums and relative paths based on them
Date Wed, 03 Sep 2014 20:48:53 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120417#comment-14120417
] 

Thiago H. de Paula Figueiredo edited comment on TAP5-2185 at 9/3/14 8:48 PM:
-----------------------------------------------------------------------------

Hello, Jochen!

Thanks for checking. :)

I disagree that this introduces problems. It just doesn't cover all possible cases. In your
webjars case, an URL with the wrong checksum results in a 404 with *or* without my fix. On
the other hand, URLs with a  wrong checksum pointing to an existing classpath or context resource
will be redirected to an URL with the right checksum and result in a 200. Good enough for
me. Of course, my fix could have provided some hook for other AssetFactory's to try to recover
wrong checksums, but I still think no URLs that worked before my fix got broken, while context
and classpath ones with wrong checksums get redirected to the correct URLs.


was (Author: thiagohp):
Hello, Jochen!

Thanks for checking. :)

I disagree that this introduces problems. It just doesn't cover all possible cases. In your
webjars case, an URL with the wrong checksum result in a 404 with *or* without my fix. On
the other hand, URLs with a  wrong checksum pointing to an existing classpath or context resource
will be redirected to an URL with the right checksum and result in a 200. Good enough for
me. Of course, my fix could have provided some hook for other AssetFactory's to try to recover
wrong checksums, but I still think no URLs that worked before my fix got broken, while context
and classpath ones with wrong checksums get redirected to the correct URLs.

> Problem with the asset checksums and relative paths based on them
> -----------------------------------------------------------------
>
>                 Key: TAP5-2185
>                 URL: https://issues.apache.org/jira/browse/TAP5-2185
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Lenny Primak
>            Assignee: Thiago H. de Paula Figueiredo
>              Labels: month-of-tapestry
>             Fix For: 5.4
>
>
> When JavaScript modules reference other (non-tapestry) JS code via relative paths,
> or absolute paths that have to be configured, the checksum is preventing
> the other resources from being accessed properly
> Discussion regarding this can be found here:
> http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Re-5-4-Problems-with-the-asset-checksums-and-relative-paths-based-on-them-td5723366.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message