tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (TAP5-2328) configuration.add(SymbolConstants.COMPONENT_RENDER_TRACING_ENABLED, "true") can break javascript by including HTML within Javascript
Date Fri, 01 Aug 2014 18:29:38 GMT

     [ https://issues.apache.org/jira/browse/TAP5-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Howard M. Lewis Ship closed TAP5-2328.
--------------------------------------

    Resolution: Won't Fix
      Assignee: Howard M. Lewis Ship

Inline JavaScript is problematic in Tapestry in a number of ways, and this option is one that
is very rarely used (certainly not in production, rarely in development).

> configuration.add(SymbolConstants.COMPONENT_RENDER_TRACING_ENABLED, "true") can break
javascript by including HTML within Javascript
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2328
>                 URL: https://issues.apache.org/jira/browse/TAP5-2328
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.4
>            Reporter: Basile Chandesris
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>              Labels: developing_environment, javascript, tml
>
> When COMPONENT_RENDER_TRACING_ENABLED is active, html comments can be included with Javascript
code.
> Context: 5.4-beta-5
> Test done with uklance/tapestry-graphael/Pie Chart: 
>   Non /META-INF/assets compliant
>   and the javascript part impacted was included in the .tml file.
> Example: https://github.com/uklance/tapestry-graphael/blob/master/tapestry-graphael-demo/src/main/resources/org/lazan/t5/graphael/demo/pages/PieChartDemo.tml
> error: 
>  ...
> \"font-weight\": 400 });\n                            }\n                        });\n
                  }\n        <!--BEGIN projects/Index:piechart (classpath:app/pages/projects/Index.tml,
line 13)-->)(chart, r);})()"
> ...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message