tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1290) Add required flag to @ActivationRequestParameter annotation
Date Mon, 30 Jun 2014 21:25:25 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048183#comment-14048183

Hudson commented on TAP5-1290:

SUCCESS: Integrated in tapestry-trunk-freestyle #1268 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1268/])
TAP5-1290: Add required flag to @ActivationRequestParameter annotation (hlship: rev 7a2f98c8edb9c0ab90b664e38ab82d420e0f446c)
* tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MissingRequiredARP.java
* tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
* tapestry-core/src/main/java/org/apache/tapestry5/annotations/ActivationRequestParameter.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ActivationRequestParameterWorker.java
* tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/ActivationRequestParameterTests.groovy

> Add required flag to @ActivationRequestParameter annotation
> -----------------------------------------------------------
>                 Key: TAP5-1290
>                 URL: https://issues.apache.org/jira/browse/TAP5-1290
>             Project: Tapestry 5
>          Issue Type: Improvement
>    Affects Versions: 5.2
>         Environment: Tapestry 5.2.0 alpha
>            Reporter: Vjeran Marcinko
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.4
> It would be really nice to have "required" argument in @ActivationRequestParameter so
one doesn't have to check it manually before page rendering begins.
> I guess many people such as me, who don't care about RESTful URLs, will find @ActivationRequestParameter
much easier way to pass render parameters than standard activation context, not just because
it offers naming and optionality, but also because one have clean separation between parameter
setting process (through this annotation) and preprocessing logic needed for some pages (placed
in onActivate, such as security check or other mutli page preprocesing logic; request filters
is sometimes too cumbersome way to achieve the same). Required flag would be nice addition
to make it truly top-level way to pass render params.

This message was sent by Atlassian JIRA

View raw message