Return-Path: X-Original-To: apmail-tapestry-commits-archive@minotaur.apache.org Delivered-To: apmail-tapestry-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DAA1112C0 for ; Mon, 19 May 2014 18:30:40 +0000 (UTC) Received: (qmail 23117 invoked by uid 500); 19 May 2014 18:30:40 -0000 Delivered-To: apmail-tapestry-commits-archive@tapestry.apache.org Received: (qmail 23089 invoked by uid 500); 19 May 2014 18:30:39 -0000 Mailing-List: contact commits-help@tapestry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tapestry.apache.org Delivered-To: mailing list commits@tapestry.apache.org Received: (qmail 23082 invoked by uid 99); 19 May 2014 18:30:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 May 2014 18:30:39 +0000 Date: Mon, 19 May 2014 18:30:39 +0000 (UTC) From: "Michael Mikhulya (JIRA)" To: commits@tapestry.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TAP5-2337) Reduce number of calls of AbstractStringBuilder.expandCapacity MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TAP5-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Mikhulya updated TAP5-2337: ----------------------------------- Attachment: 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu.patch > Reduce number of calls of AbstractStringBuilder.expandCapacity > -------------------------------------------------------------- > > Key: TAP5-2337 > URL: https://issues.apache.org/jira/browse/TAP5-2337 > Project: Tapestry 5 > Issue Type: Improvement > Reporter: Michael Mikhulya > Priority: Minor > Labels: performance > Attachments: 0001-TAP5-2337-Reduce-number-of-calls-of-AbstractStringBu.patch > > > During profiling of Tapestry framework I found that AbstractStringBuilder.expandCapacity is called very frequently. > There is a patch that get rid of creation StringBuilder with following calls of expandCapacity (which allocate memory and copy current content into it). > I have to thank Dmitriy Ilyin, who helped me to investigate the issue and to find the simplest solution (actually we get a little bit less code while improving performance). > With this improvement time per request decreased on 0.5ms (1% of overall time)on our test. All measurements were done with apache benchmark after warm up phase. -- This message was sent by Atlassian JIRA (v6.2#6252)