tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Mikhulya (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAP5-2335) Decrease number of operations with HashMap #2
Date Mon, 19 May 2014 17:00:43 GMT

     [ https://issues.apache.org/jira/browse/TAP5-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Mikhulya updated TAP5-2335:
-----------------------------------

    Attachment: 0001-TAP5-2335-Decrease-number-of-operations-with-HashMap.patch

> Decrease number of operations with HashMap #2
> ---------------------------------------------
>
>                 Key: TAP5-2335
>                 URL: https://issues.apache.org/jira/browse/TAP5-2335
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Michael Mikhulya
>         Attachments: 0001-TAP5-2335-Decrease-number-of-operations-with-HashMap.patch
>
>
> During profiling of tapestry framework I found that HashMap is actively used in following
code:
> {code:title=NamedSet.java}
> public void eachValue(Worker<T> worker)
>     {
>         F.flow(getValues()).each(worker);
>     }
> {code}
> Here HashSet (which internally uses HashMap) is created inside getValues() only to iterate
over it.
> I changed code to use ArrayList instead of HashSet.
> With following patch time per request decreased on 3.5 ms (7.4% of overall time). Measurements
were done with apache benchmark on a real application after warm up phase.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message