tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thiago H. de Paula Figueiredo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2332) Get rid of String.format usage
Date Wed, 21 May 2014 20:28:38 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005181#comment-14005181
] 

Thiago H. de Paula Figueiredo commented on TAP5-2332:
-----------------------------------------------------

These performance comparisons, sometimes, have some code which is quite far from the tested
specific framework. And many times they test meaningless stuff. For example, take a look at
the "Tapestry JSON benchmark" at https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/tapestry/hello/src/main/java/hello/pages/HelloJSON.java.
It's not testing the performance of the Tapestry JSON classes *at all*. Actually, it maps
a Map<String, String> to JSON using Jackson Mapper then returns it as a StreamResponse.
Same for the "Database Mapping Test", it's basically using Hibernate, Jackson Mapper and MySQL
and calling it a Tapestry framework: https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/tapestry/hello/src/main/java/hello/pages/HelloDB.java.

> Get rid of String.format usage
> ------------------------------
>
>                 Key: TAP5-2332
>                 URL: https://issues.apache.org/jira/browse/TAP5-2332
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Michael Mikhulya
>            Priority: Minor
>              Labels: performance
>         Attachments: 0001-TAP5-2332-get-rid-of-String.format-usage.patch
>
>
> During profiling I found that String.format provides much load on CPU.
> In many cases in Tapestry String.format can be easily replaced with simple String concatenation.
> Simple JMH (http://openjdk.java.net/projects/code-tools/jmh/) test
> {code:java}
> public class FormatVsConcat {
>     private static final String format = "This is a test string with %s";
>     private static final String concat1 = "This is a test string with ";
>     private static final String concat2 = "test word";
>     @GenerateMicroBenchmark
>     public String format() {
>         return String.format(format, concat2);
>     }
>     @GenerateMicroBenchmark
>     public String concat() {
>         return concat1 + concat2;
>     }
> }
> {code}
> shows, that concatenation is 366(!) times faster.
> I removed only hot places in tapestry and get following results with apache benchmark:
> *Not patched* tapestry version:
> Requests per second: *21.38 /sec* (mean)
> Time per request: *46.764 [ms]* (mean)
> *Patched* tapestry version:
> Requests per second: *27.77 /sec* (mean)
> Time per request: *36.013 [ms]* (mean)
> So we gained 10ms per request or 20% of rendering time.
> If you don't mind I would like to get rid of String.format in all places of Tapestry
and provide patch. I fixed only hot places which appeared during ab-profiling of one concrete
page. So it is very likely that not all hot places were found and fixed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message