tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2219) XML-Parsing broken if system encoding is not UTF-8
Date Sun, 27 Apr 2014 13:55:17 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982322#comment-13982322
] 

ASF subversion and git services commented on TAP5-2219:
-------------------------------------------------------

Commit 1a37c6abd59254d3e9e6ce676cd7b300d704ecac in tapestry-5's branch refs/heads/master from
[~jkemnade]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=1a37c6a ]

TAP5-2219, TAP5-1778, TAP5-1714: when transforming the template stream, use the same encoding
for the input and the output


> XML-Parsing broken if system encoding is not UTF-8
> --------------------------------------------------
>
>                 Key: TAP5-2219
>                 URL: https://issues.apache.org/jira/browse/TAP5-2219
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.4
>         Environment: Windows (probably linux too but most systems run with utf-8)
>            Reporter: Michael Wyraz
>            Assignee: Jochen Kemnade
>         Attachments: XMLTokenStreamTests.java
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Tapestry reads tml files in XMLTokenStream.openStream(), does some doctype "magic" and
writes all the file content's into a ByteOutputStream. On T5.3 reading/writing was done using
the system's caracter encoding. With T5.4 that was changed for the reader but not for the
writer. This messes up all non-ascii characters if system encoding is not utf-8.
> Solution: Change
>         PrintWriter writer = new PrintWriter(bos);
> To
>         PrintWriter writer = new PrintWriter(new OutputStreamWriter(bos, "UTF8"));
> in XMLTokenStream.openStream().
> TODO: Unit test for XMLTokenStream (follows soon)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message