tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-2101) BeanEditor should always provide a new BeanValidationContext (JSR-303)
Date Tue, 23 Apr 2013 17:51:16 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639302#comment-13639302
] 

Hudson commented on TAP5-2101:
------------------------------

Integrated in tapestry-trunk-freestyle #1052 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1052/])
    FIXED - TAP5-2101: BeanEditor should always provide a new (Revision 349ef622030ed5f1bfb098829321f753b4e19843)

     Result = SUCCESS
kaosko : 
Files : 
* tapestry-core/src/main/java/org/apache/tapestry5/internal/BeanEditContextImpl.java
* tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/BeanEditor.java
* tapestry-core/src/test/java/org/apache/tapestry5/corelib/components/BeanEditorTest.java

                
> BeanEditor should always provide a new BeanValidationContext (JSR-303)
> ----------------------------------------------------------------------
>
>                 Key: TAP5-2101
>                 URL: https://issues.apache.org/jira/browse/TAP5-2101
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-beanvalidator
>            Reporter: Luca Menegus
>            Assignee: Kalle Korhonen
>             Fix For: 5.3.7, 5.4
>
>         Attachments: beaneditor-jsr303.patch, TAP5-2101-2.patch
>
>
> We found that the current BeanEditor implementation:
> * fails to beanvalidate (JSR-303) complex beans (beans that contain other beans)
> * fails to validate more than one bean in the same page (when more than one BeanEditor
is present in teh page)
> The problem is that  BeanEditor doesn't provide the correct BeanValidationContext to
the validation framework.
> Given the following beans:
> public class ComplexBean {
>     private SomeSimpleBean someSimpleBean;
>    @NotNull private String simpleNotNullProperty;
>     ...
> }
> public class SimpleBean {
>     @Min(6) private int minValue;
>  ..
> }
> One would expect that the following page would validate all the constraint from both
ComplexBean and SimpleBean:
> <t:form validate="complexBean">
>         	<t:BeanEditor object="complexBean" />
>         	<t:BeanEditor object="complexBean.someSimpleBean" />
> ...
> Instead only ComplexBean.simpleNotNullProperty constraint is validated.
> Moreover not even:
> <t:form validate="this"> 
> <t:BeanEditor object="beanA" /> 
> <t:BeanEditor object=" beanB " /> 
> <t:form/> 
> Is (bean)validating properly....
> BeanEditor should provide the validation framework with a new BeanValidationContext bound
to the object being validated all the times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message