tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hls...@apache.org
Subject [1/4] git commit: Remove unnecessary FormFragment event
Date Thu, 03 Jan 2013 20:13:15 GMT
Remove unnecessary FormFragment event


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2cf75893
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2cf75893
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2cf75893

Branch: refs/heads/master
Commit: 2cf75893a6a10c040d2686e6664d66d307054d3c
Parents: 108db6b
Author: Howard M. Lewis Ship <hlship@apache.org>
Authored: Thu Jan 3 10:22:09 2013 -0800
Committer: Howard M. Lewis Ship <hlship@apache.org>
Committed: Thu Jan 3 10:22:09 2013 -0800

----------------------------------------------------------------------
 .../META-INF/modules/t5/core/events.coffee         |    4 ----
 .../META-INF/modules/t5/core/form-fragment.coffee  |    7 +------
 2 files changed, 1 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2cf75893/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/events.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/events.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/events.coffee
index c9d7337..94e2901 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/events.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/events.coffee
@@ -159,7 +159,3 @@ define
     # boolean. The fragment will show or hide itself if necessary (triggering the `element.didShow`
or
     # `element.didHide` event).
     changeVisibility: "t5:fragment:change-visibility"
-    # Requests that the fragment remove itself entirely. This event is of no practical use,
as it is simply equivalent
-    # to invoking `dom/ElementWrapper.remove()` on the fragment's element; the event exists
for compatibility with
-    # Tapestry 5.3 and will be removed in Tapestry 5.5.
-    remove: "t5:fragment:remove"

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2cf75893/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
index 0110f3d..aae2623 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
@@ -20,12 +20,6 @@ define ["_", "./dom", "./events", "./forms"],
 
     SELECTOR = "[data-component-type='core/FormFragment']"
 
-    # This is mostly for compatibility with 5.3, which supported
-    # a DOM event to ask a fragment to remove itself.  This makes less sense since
-    # default animations were eliminated in 5.4.
-    dom.onDocument events.formfragment.remove, SELECTOR, (event) ->
-      this.remove()
-
     # When any form fires the prepareForSubmit event, check to see if
     # any form fragments are contained within, and give them a chance
     # to enabled/disable their hidden field.
@@ -77,4 +71,5 @@ define ["_", "./dom", "./events", "./forms"],
       else
         trigger.on "click", update
 
+    # Module exports:
     { linkTrigger }


Mime
View raw message