tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Gonschorek (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TAP5-1941) Alerts component should check for XHR request in "dismiss" event handler
Date Tue, 29 May 2012 09:46:23 GMT
Felix Gonschorek created TAP5-1941:
--------------------------------------

             Summary: Alerts component should check for XHR request in "dismiss" event handler
                 Key: TAP5-1941
                 URL: https://issues.apache.org/jira/browse/TAP5-1941
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3.3
            Reporter: Felix Gonschorek
            Priority: Minor


The Alerts component does not check for request.isXHR() in the "onDismiss" event handler.


Crawlers (Googlebot) send non-xhr requests to the "onDismiss" event-url and generate errors
on my server, because the returned JSONObject is not a valid return value from an event handler.

org.apache.tapestry5.runtime.ComponentEventException: A component event handler method returned
the value {}. Return type org.apache.tapestry5.json.JSONObject can not be handled. 

A check for request.isXHR() and a conditional return value (null for non-ajax requests, the
json object for ajax requests) should fix this.

thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message