tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoff Callender (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (TAP5-812) The input validation documentation incorrectly shows validation occuring in the success event handler method
Date Sun, 15 Apr 2012 13:41:19 GMT

    [ https://issues.apache.org/jira/browse/TAP5-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254332#comment-13254332
] 

Geoff Callender edited comment on TAP5-812 at 4/15/12 1:41 PM:
---------------------------------------------------------------

Nope, example in doco hasn't changed yet. 
The doco page is http://tapestry.apache.org/forms-and-validation.html
                
      was (Author: geoffcallender):
    Nope, example in doco still needs to change. 
The doco page is http://tapestry.apache.org/forms-and-validation.html
                  
> The input validation documentation incorrectly shows validation occuring in the success
event handler method
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-812
>                 URL: https://issues.apache.org/jira/browse/TAP5-812
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 5.3.2, 5.1.0.5
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.0
>
>
> The example in http://tapestry.apache.org/tapestry5/guide/validation.html has to be fixed
as a consequence of TAPESTRY-1972 .
> Instead of this...
>     String onSuccess()
>     {
>         if (!authenticator.isValid(userName, password))
>         {
>             form.recordError(passwordField, "Invalid user name or password.");
>             return null;
>         }
>         return "PostLogin";
>     }
> ...it should be...
>    String onValidateForm()
>    {
>        if (!authenticator.isValid(userName, password))
>        {
>            form.recordError(passwordField, "Invalid user name or password.");
>        }
>    }
>    String onSuccess()
>    {
>        return "PostLogin";
>    }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message