tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Wyraz (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1844) Datefield not fires onchange event on changes
Date Mon, 12 Mar 2012 12:31:34 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227461#comment-13227461
] 

Michael Wyraz commented on TAP5-1844:
-------------------------------------

Patch for 5.3 Branch:


Index: tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
===================================================================
--- tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
      (Revision 1299618)
+++ tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
      (Arbeitskopie)
@@ -114,7 +114,10 @@
             var date = this.datePicker.getDate();

             var resultHandler = function(result) {
-                this.field.value = result;
+               if (this.field.value != result) {
+                    this.field.value = result;
+                    if (this.field.onchange) this.field.onchange();
+               }

                 this.hidePopup();

                
> Datefield not fires onchange event on changes
> ---------------------------------------------
>
>                 Key: TAP5-1844
>                 URL: https://issues.apache.org/jira/browse/TAP5-1844
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.1
>            Reporter: Michael Wyraz
>
> It's a "regression" to TAPESTRY-238
> in datefield.js when setting the field's value, onchange() must be called if it exists

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message