tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Riedel (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1768) @ActivationRequestParameter does not encode to be URL friendly
Date Sat, 31 Dec 2011 14:54:30 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178024#comment-13178024
] 

Christian Riedel commented on TAP5-1768:
----------------------------------------

If you have a property in you page, let's say this one:

    @ActivationRequestParameter("error_description")
    private String errorDescription;

and the error description is encoded like this:
...?error_description=This+Is+Some+Error+Description

then the ActivationRequestParameterWorker or to be more precise the URLEncoderImpl will throw
an exception telling me there's an illegal character in my URL.
The '+' resolves to a space and spaces are not within the 'safe' BitSet within URLEncoderImpl.
I encountered this while trying to read facebook error messages in my app (they are always
passed as query parameters attached to a defined redirectURI).
I'm not able to change the way FB adds these parameters. 

Would you mind changing the behaviour again to be less strict about the value of query parameters?

Cheers
Christian
                
> @ActivationRequestParameter does not encode to be URL friendly
> --------------------------------------------------------------
>
>                 Key: TAP5-1768
>                 URL: https://issues.apache.org/jira/browse/TAP5-1768
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.3, 5.2
>            Reporter: Ryan How
>            Assignee: Ulrich Stärk
>             Fix For: 5.3.1, 5.4
>
>
> The @ActivationRequestParameter can contain symbols that interfere with the URL (eg.
&) and these are passed straight to the browser and are not encoded. Therefore the query
string in any links that are generated are all messed up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message