tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Harner (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (TAP5-1628) Have Submit documentation explicitly state when the disabled attribute is evaluated
Date Wed, 07 Sep 2011 00:23:09 GMT

     [ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Bob Harner resolved TAP5-1628.

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Bob Harner

Fixed in rev 1165938, although with different text:

     If true, then the field will render out with a disabled attribute
     (to turn off client-side behavior). When the form is submitted, disabled
     fields' values are ignored (not even validated), and the component's
     events, if any, are not fired.

But I'm not sure a better description of the disabled parameter helps people know when to
apply the @Persist annotation.

> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>                 Key: TAP5-1628
>                 URL: https://issues.apache.org/jira/browse/TAP5-1628
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 5.3
>            Reporter: Steve Eynon
>            Assignee: Bob Harner
>            Priority: Trivial
>              Labels: submit
>             Fix For: 5.3
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission
and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing
our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject'
because null / false on form submission. As our submit button was enabled and the form submitted,
we saw no reason for the event not to fire.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message