tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1632) When a submit component does not have a specific id, the default id "submit" collides ont the client side with the HTMLFormElement.submit() method, causing JavaScript errors when the form is submitted
Date Wed, 07 Sep 2011 22:43:08 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099624#comment-13099624
] 

Hudson commented on TAP5-1632:
------------------------------

Integrated in tapestry-trunk-freestyle #507 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/507/])
    TAP5-1632: When a submit component does not have a specific id, the default id "submit"
collides ont the client side with the HTMLFormElement.submit() method, causing JavaScript
errors when the form is submitted

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166423
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/InternalSymbols.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/CanceledEventDemo.tml
* /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/CanceledEventTests.groovy
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/CanceledEventDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java


> When a submit component does not have a specific id, the default id "submit" collides
ont the client side with the HTMLFormElement.submit() method, causing JavaScript errors when
the form is submitted
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1632
>                 URL: https://issues.apache.org/jira/browse/TAP5-1632
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3, 5.2.5
>            Reporter: Yohan Yudanara
>            Assignee: Howard M. Lewis Ship
>              Labels: component, submit
>             Fix For: 5.3
>
>
> "cancel" mode of submit component is not submit to server, if we don't give t:id attribute
on Submit component.
> Steps to reproduce:
> <t:form t:id="form">
>        	<t:textfield t:id="testField" t:value="testField" t:validate="required" />
>        	<t:submit value="normal submit"/>
>        	<t:submit mode="cancel" value="cancel submit"/>
> </t:form>
> When clicking on "cancel submit", nothing happen (form is not submitted to server).
> --------------------
> Workaround from Josh Canfield is to give t:id attribute on Submit component:
> <t:form t:id="form">
>        	<t:textfield t:id="testField" t:value="testField" t:validate="required" />
>        	<t:submit t:id="normalSubmit" value="normal submit"/>
>        	<t:submit t:id="cancelSubmit" mode="cancel" value="cancel submit"/>
> </t:form>
> --------------------
> This is caused by tapestry gives default id 'submit' to the Submit component. 
> Tapestry should never give default id 'submit' to the Submit component to avoid this
defect.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message