Return-Path: 
 <commits-return-9440-apmail-tapestry-commits-archive=tapestry.apache.org@tapestry.apache.org>
Delivered-To: apmail-tapestry-commits-archive@minotaur.apache.org
Received: (qmail 39209 invoked from network); 2 Oct 2010 00:58:56 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 2 Oct 2010 00:58:56 -0000
Received: (qmail 97588 invoked by uid 500); 2 Oct 2010 00:58:56 -0000
Delivered-To: apmail-tapestry-commits-archive@tapestry.apache.org
Received: (qmail 97478 invoked by uid 500); 2 Oct 2010 00:58:55 -0000
Mailing-List: contact commits-help@tapestry.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@tapestry.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@tapestry.apache.org>
List-Post: <mailto:commits@tapestry.apache.org>
List-Id: <commits.tapestry.apache.org>
Reply-To: dev@tapestry.apache.org
Delivered-To: mailing list commits@tapestry.apache.org
Received: (qmail 97471 invoked by uid 99); 2 Oct 2010 00:58:55 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Oct 2010 00:58:55 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Oct 2010 00:58:55 +0000
Received: from thor (localhost [127.0.0.1])
	by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o920wYpU002023
	for <commits@tapestry.apache.org>; Sat, 2 Oct 2010 00:58:35 GMT
Message-ID: <5984992.508111285981114675.JavaMail.jira@thor>
Date: Fri, 1 Oct 2010 20:58:34 -0400 (EDT)
From: "Howard M. Lewis Ship (JIRA)" <jira@apache.org>
To: commits@tapestry.apache.org
Subject: [jira] Closed: (TAP5-731) PageLink should fill src rather than href
 on img tags
In-Reply-To: <704488375.1243939627728.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/TAP5-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-731.
-------------------------------------

    Resolution: Invalid

You can create a component to combine a PageLink with an <img> tag.

> PageLink should fill src rather than href on img tags
> -----------------------------------------------------
>
>                 Key: TAP5-731
>                 URL: https://issues.apache.org/jira/browse/TAP5-731
>             Project: Tapestry 5
>          Issue Type: Improvement
>    Affects Versions: 5.1.0.0, 5.1.0.1, 5.1.0.2, 5.1.0.3, 5.1.0.4, 5.1.0.5, 5.0.15, 5.0.16, 5.0.17, 5.0.18
>            Reporter: Andy Buckley
>            Priority: Minor
>
> If I use a PageLink as hidden markup on a normal <a> link, the href attribute is replaced as expected:
> <!-- Link to a generated image -->
> <a href="#" t:type="pagelink" t:page="plotimage"
> t:context="imagename">foo</a>
> produces
> <a href="/plotimage/my-image-a-b-c.png">foo</a>
> It would be nice to use the same simple idiom for producing generated inline images, e.g.
> <img src="#" t:type="pagelink" t:page="plotimage"
> t:context="imagename" />
> However, rather than fill the "src" attribute, Tapestry adds an unused href again:
> <img src="#" href="/plotimage/my-image-a-b-c.png"/>
> It would be good if PageLink would treat <img> tags differently from other tags and fill the "src" attribute, so that the bulky workaround with injected ComponentResources being used to create an ActionLink isn't necessary.
> I *think* <img> is the only HTML tag with a name other than "href" for URLs, but if not then please treat this as being a request that PageLink should fill the appropriate URL attribute on any tag it's attached to.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.