Return-Path: Delivered-To: apmail-tapestry-commits-archive@minotaur.apache.org Received: (qmail 36261 invoked from network); 30 Jun 2009 18:16:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 30 Jun 2009 18:16:59 -0000 Received: (qmail 7086 invoked by uid 500); 30 Jun 2009 18:17:09 -0000 Delivered-To: apmail-tapestry-commits-archive@tapestry.apache.org Received: (qmail 7009 invoked by uid 500); 30 Jun 2009 18:17:09 -0000 Mailing-List: contact commits-help@tapestry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tapestry.apache.org Delivered-To: mailing list commits@tapestry.apache.org Received: (qmail 7000 invoked by uid 99); 30 Jun 2009 18:17:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2009 18:17:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2009 18:17:07 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3457B234C004 for ; Tue, 30 Jun 2009 11:16:47 -0700 (PDT) Message-ID: <1057603121.1246385807209.JavaMail.jira@brutus> Date: Tue, 30 Jun 2009 11:16:47 -0700 (PDT) From: "Howard M. Lewis Ship (JIRA)" To: commits@tapestry.apache.org Subject: [jira] Created: (TAP5-760) The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org The Form event "validateForm" is awkward, a new name (perhaps "formValidate") would be nice ------------------------------------------------------------------------------------------- Key: TAP5-760 URL: https://issues.apache.org/jira/browse/TAP5-760 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.1.0.5 Reporter: Howard M. Lewis Ship Priority: Minor You end up with methods like onValidateFormFromLogin() which is just asking for trouble. onFormValidateFromLogin() is a bit better. Obviously, we keep the old name as well ... have to fire two events at the validate form stage. What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.