tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkuhn...@apache.org
Subject svn commit: r463883 - /tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js
Date Sat, 14 Oct 2006 02:05:30 GMT
Author: jkuhnert
Date: Fri Oct 13 19:05:28 2006
New Revision: 463883

URL: http://svn.apache.org/viewvc?view=rev&rev=463883
Log:
Fixed a bug with client side event handling. Ouch...

In IE, when calling dojo.event.browser.clean() all node event listeners are successfully detached.
This doesn't do the
same thing at all in moz since it doesn't attach events to the same property types. Sooooo......Multiple
calls to connect 
from moz result in multiple listeners and the same in IE works "as expected". 


Modified:
    tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js?view=diff&rev=463883&r1=463882&r2=463883
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js Fri Oct 13 19:05:28
2006
@@ -61,7 +61,9 @@
 		// make sure id is correct just in case node passed in has only name
 		id=form.getAttribute("id");
 		
-		if (!this.forms[id]) {
+		// previously connected, cleanup and connect aga
+		if (!this.forms[id] || (this.forms[id] && dojo.render.html.ie)) {
+			
 			this.forms[id]={};
 			this.forms[id].validateForm=true;
 			this.forms[id].profiles=[];
@@ -92,7 +94,7 @@
 				});
 			}
 		} else {
-			dojo.log.warn("registerForm(" + id + ") Form already registered.");
+			dojo.log.debug("registerForm(" + id + ") Form already registered, ignoring.");
 		}
 	},
 	



Mime
View raw message