tapestry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkuhn...@apache.org
Subject svn commit: r431194 - in /tapestry/tapestry4/trunk/tapestry-framework/src: java/org/apache/tapestry/AbstractComponent.java java/org/apache/tapestry/form/AbstractFormComponent.java js/tapestry/form.js
Date Sun, 13 Aug 2006 16:41:24 GMT
Author: jkuhnert
Date: Sun Aug 13 09:41:23 2006
New Revision: 431194

URL: http://svn.apache.org/viewvc?rev=431194&view=rev
Log:
Bug fix for TAPESTRY-1054. The abstract clientId setter on AbstractForm was blowing away all
the clientId logic 
setup in AbstractComponent. Removing this and adding a protected setter seems to fix these
problems.

Modified:
    tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/AbstractComponent.java
    tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractFormComponent.java
    tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/AbstractComponent.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/AbstractComponent.java?rev=431194&r1=431193&r2=431194&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/AbstractComponent.java
(original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/AbstractComponent.java
Sun Aug 13 09:41:23 2006
@@ -450,6 +450,11 @@
         return boundId;
     }
     
+    protected void setClientId(String id)
+    {
+        _clientId = id;
+    }
+    
     String getBoundId()
     {
         if (_bindings == null)

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractFormComponent.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractFormComponent.java?rev=431194&r1=431193&r2=431194&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractFormComponent.java
(original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractFormComponent.java
Sun Aug 13 09:41:23 2006
@@ -60,12 +60,6 @@
     public abstract String getIdParameter();
 
     /**
-     * Stores the actual id allocated (or null if the component doesn't support this).
-     */
-
-    public abstract void setClientId(String id);
-
-    /**
      * Invoked from {@link #renderFormComponent(IMarkupWriter, IRequestCycle)} (that is,
an
      * implementation in a subclass), to obtain an id and render an id attribute. Reads
      * {@link #getIdParameter()}.

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js?rev=431194&r1=431193&r2=431194&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/form.js Sun Aug 13 09:41:23
2006
@@ -177,7 +177,6 @@
 	 * 				   not specified assumes true.
 	 */
 	setFormValidating:function(formId, validate){
-		dojo.log.warn("setFormValidating called with value " + validate);
 		if (this.forms[formId]){
 			this.forms[formId].validateForm = validate ? true : false;
 		}



Mime
View raw message