tamaya-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tamaya-site] ottlinger commented on a change in pull request #4: TAMAYA-374 version substitution in source blocks
Date Thu, 16 May 2019 07:35:16 GMT
ottlinger commented on a change in pull request #4: TAMAYA-374 version substitution in source
blocks
URL: https://github.com/apache/incubator-tamaya-site/pull/4#discussion_r284572938
 
 

 ##########
 File path: jbake.properties
 ##########
 @@ -15,8 +15,8 @@ default.status=published
 template.encoding=UTF-8
 # Make properties available in templates
 asciidoctor.attributes.export=true
-asciidoctor.attributes.prefix=jbake-
 twitterhandle=tamayaconf
 tamaya_version_released=0.3-incubating
+tamaya_version_development=0.4-incubating-SNAPSHOT
 
 Review comment:
   @peculater thanks for spotting the mistake - we should use tamaya_version_released everywhere.
To my mind it's confusing to have 2 versions in the docs.
   
   If there are no other references (errors) to this property in other adoc-files the PR is
ready to be merged :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message