tamaya-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] acoburn opened a new pull request #27: TAMAYA-379: Enforce checkstyle rules
Date Tue, 22 Jan 2019 04:59:56 GMT
acoburn opened a new pull request #27: TAMAYA-379: Enforce checkstyle rules
URL: https://github.com/apache/incubator-tamaya-extensions/pull/27
 
 
   There are three categories of changes here:
   
   * Tabs change to spaces
   * Unused imports are removed
   * StarImports are replaced with explicit imports
   * Missing JavaDocs are added
   
   I made one modification to the checkstyle rules so that the existing method names in the
gogo-shell module pass the `MethodName` check. These methods tend to follow this pattern:
`tm_propertysources`, `tm_apply_config`, etc. (Another possibility would be to add a corresponding
suppression, specific to the gogo-shell module for this pattern, or we could change the method
names to follow more typical conventions).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message