Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D359A200D5B for ; Wed, 29 Nov 2017 00:08:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D193B160C15; Tue, 28 Nov 2017 23:08:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F1310160BE7 for ; Wed, 29 Nov 2017 00:08:52 +0100 (CET) Received: (qmail 72763 invoked by uid 500); 28 Nov 2017 23:08:52 -0000 Mailing-List: contact commits-help@tamaya.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tamaya.incubator.apache.org Delivered-To: mailing list commits@tamaya.incubator.apache.org Received: (qmail 72754 invoked by uid 99); 28 Nov 2017 23:08:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2017 23:08:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 647081A141F for ; Tue, 28 Nov 2017 23:08:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.222 X-Spam-Level: X-Spam-Status: No, score=-4.222 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id W7yB1tg0fR8I for ; Tue, 28 Nov 2017 23:08:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 2CAA75F232 for ; Tue, 28 Nov 2017 23:08:49 +0000 (UTC) Received: (qmail 72735 invoked by uid 99); 28 Nov 2017 23:08:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2017 23:08:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A6020DFB78; Tue, 28 Nov 2017 23:08:48 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: pottlinger@apache.org To: commits@tamaya.incubator.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: incubator-tamaya-sandbox git commit: TAMAYA-218: Fix warnings. Date: Tue, 28 Nov 2017 23:08:48 +0000 (UTC) archived-at: Tue, 28 Nov 2017 23:08:54 -0000 Repository: incubator-tamaya-sandbox Updated Branches: refs/heads/master 122222ca3 -> bb340e091 TAMAYA-218: Fix warnings. Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/commit/bb340e09 Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/tree/bb340e09 Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/diff/bb340e09 Branch: refs/heads/master Commit: bb340e09107bd9bf487557c31bde390058add076 Parents: 122222c Author: Phil Ottlinger Authored: Wed Nov 29 00:04:44 2017 +0100 Committer: Phil Ottlinger Committed: Wed Nov 29 00:04:44 2017 +0100 ---------------------------------------------------------------------- .../apache/tamaya/metamodel/CachedFilter.java | 4 ++-- .../tamaya/metamodel/EnabledPropertySource.java | 15 ++++++------- .../org/apache/tamaya/metamodel/HideFilter.java | 5 ++--- .../tamaya/metamodel/MetaConfiguration.java | 22 ++++++++++---------- .../apache/tamaya/metamodel/Refreshable.java | 2 -- 5 files changed, 21 insertions(+), 27 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/blob/bb340e09/metamodel/src/main/java/org/apache/tamaya/metamodel/CachedFilter.java ---------------------------------------------------------------------- diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/CachedFilter.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/CachedFilter.java index d2a343c..b9cd370 100644 --- a/metamodel/src/main/java/org/apache/tamaya/metamodel/CachedFilter.java +++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/CachedFilter.java @@ -109,8 +109,8 @@ public class CachedFilter implements PropertyFilter{ } private static final class CachedEntry{ - long ttl; - PropertyValue value; + private long ttl; + private PropertyValue value; public CachedEntry (PropertyValue value, long ttl){ this.ttl = ttl; http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/blob/bb340e09/metamodel/src/main/java/org/apache/tamaya/metamodel/EnabledPropertySource.java ---------------------------------------------------------------------- diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/EnabledPropertySource.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/EnabledPropertySource.java index 2dcf101..3eafd38 100644 --- a/metamodel/src/main/java/org/apache/tamaya/metamodel/EnabledPropertySource.java +++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/EnabledPropertySource.java @@ -18,19 +18,16 @@ */ package org.apache.tamaya.metamodel; -import org.apache.tamaya.metamodel.internal.resolver.JavaResolver; -import org.apache.tamaya.spi.PropertySource; -import org.apache.tamaya.spi.PropertyValue; -import org.apache.tamaya.spisupport.PropertySourceComparator; - -import javax.script.ScriptEngine; -import javax.script.ScriptEngineManager; -import javax.script.ScriptException; import java.util.Collections; import java.util.Map; import java.util.Objects; import java.util.logging.Logger; +import org.apache.tamaya.metamodel.internal.resolver.JavaResolver; +import org.apache.tamaya.spi.PropertySource; +import org.apache.tamaya.spi.PropertyValue; +import org.apache.tamaya.spisupport.PropertySourceComparator; + /** * Wrapped property source that allows enabling a property source using an @@ -113,7 +110,7 @@ public final class EnabledPropertySource @Override public String toString() { - return "DynamicPropertySource{" + + return "EnabledPropertySource{" + "\n enabled=" + enabledExpression + "\n wrapped=" + wrapped + '}'; http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/blob/bb340e09/metamodel/src/main/java/org/apache/tamaya/metamodel/HideFilter.java ---------------------------------------------------------------------- diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/HideFilter.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/HideFilter.java index 6a1e116..7e02333 100644 --- a/metamodel/src/main/java/org/apache/tamaya/metamodel/HideFilter.java +++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/HideFilter.java @@ -18,13 +18,12 @@ */ package org.apache.tamaya.metamodel; +import java.util.Map; + import org.apache.tamaya.metamodel.spi.ItemFactory; import org.apache.tamaya.spi.FilterContext; import org.apache.tamaya.spi.PropertyFilter; import org.apache.tamaya.spi.PropertyValue; -import org.apache.tamaya.spi.PropertyValueBuilder; - -import java.util.Map; /** * Simple filter that never changes a key/value pair returned, regardless if a value http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/blob/bb340e09/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaConfiguration.java ---------------------------------------------------------------------- diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaConfiguration.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaConfiguration.java index d896cb0..a08e418 100644 --- a/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaConfiguration.java +++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/MetaConfiguration.java @@ -18,26 +18,26 @@ */ package org.apache.tamaya.metamodel; +import java.io.File; +import java.io.IOException; +import java.net.MalformedURLException; +import java.net.URL; +import java.util.Objects; +import java.util.logging.Level; +import java.util.logging.Logger; + +import javax.xml.parsers.DocumentBuilderFactory; +import javax.xml.parsers.ParserConfigurationException; + import org.apache.tamaya.ConfigException; import org.apache.tamaya.Configuration; import org.apache.tamaya.ConfigurationProvider; import org.apache.tamaya.metamodel.spi.MetaConfigurationReader; import org.apache.tamaya.spi.ConfigurationBuilder; -import org.apache.tamaya.spi.ConfigurationContext; import org.apache.tamaya.spi.ServiceContextManager; import org.w3c.dom.Document; import org.xml.sax.SAXException; -import javax.xml.parsers.DocumentBuilderFactory; -import javax.xml.parsers.ParserConfigurationException; -import java.io.File; -import java.io.IOException; -import java.net.MalformedURLException; -import java.net.URL; -import java.util.Objects; -import java.util.logging.Level; -import java.util.logging.Logger; - /** * Accessor singleton for accessing/loading meta-configuration. */ http://git-wip-us.apache.org/repos/asf/incubator-tamaya-sandbox/blob/bb340e09/metamodel/src/main/java/org/apache/tamaya/metamodel/Refreshable.java ---------------------------------------------------------------------- diff --git a/metamodel/src/main/java/org/apache/tamaya/metamodel/Refreshable.java b/metamodel/src/main/java/org/apache/tamaya/metamodel/Refreshable.java index dc51554..60ece93 100644 --- a/metamodel/src/main/java/org/apache/tamaya/metamodel/Refreshable.java +++ b/metamodel/src/main/java/org/apache/tamaya/metamodel/Refreshable.java @@ -18,8 +18,6 @@ */ package org.apache.tamaya.metamodel; -import org.apache.tamaya.spi.ConfigurationContext; - /** * Common interface for refreshable items. */