tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-2184) Can not run Tajo with non-default $TAJO_CONF_DIR
Date Fri, 16 Mar 2018 09:44:00 GMT

    [ https://issues.apache.org/jira/browse/TAJO-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401679#comment-16401679
] 

ASF GitHub Bot commented on TAJO-2184:
--------------------------------------

hyunsik closed pull request #1051: TAJO-2184: Can not run Tajo with non-default $TAJO_CONF_DIR
URL: https://github.com/apache/tajo/pull/1051
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tajo-dist/src/main/bin/start-tajo.sh b/tajo-dist/src/main/bin/start-tajo.sh
index ef816f3289..c90e6d80cb 100755
--- a/tajo-dist/src/main/bin/start-tajo.sh
+++ b/tajo-dist/src/main/bin/start-tajo.sh
@@ -32,7 +32,7 @@ if [ "$AUTOHA_ENABLED" = "true" ]; then
   if [ -f "${TAJO_CONF_DIR}/masters" ]; then
     MASTER_FILE=${TAJO_CONF_DIR}/masters
     MASTER_NAMES=$(cat "$MASTER_FILE" | sed  's/#.*$//;/^$/d')
-    "$bin/tajo-daemons.sh" --hosts masters cd "$TAJO_HOME" \; "$bin/tajo-daemon.sh" start
master
+    "$bin/tajo-daemons.sh" --hosts masters cd "$TAJO_HOME" \; "$bin/tajo-daemon.sh" --config
$TAJO_CONF_DIR start master
   fi
 else
   echo "Starting single TajoMaster"
@@ -46,10 +46,10 @@ fi
 
 
 if [ "$TAJO_PULLSERVER_STANDALONE" = "true" ]; then
-  "$bin/tajo-daemons.sh" cd "$TAJO_HOME" \; "$bin/tajo-daemon.sh" start pullserver
+  "$bin/tajo-daemons.sh" cd "$TAJO_HOME" \; "$bin/tajo-daemon.sh" --config $TAJO_CONF_DIR
start pullserver
 fi
 
-"$bin/tajo-daemons.sh" cd "$TAJO_HOME" \; "$bin/tajo-daemon.sh" start worker
+"$bin/tajo-daemons.sh" cd "$TAJO_HOME" \; "$bin/tajo-daemon.sh" --config $TAJO_CONF_DIR start
worker
 
 # Display WEB UI URL and TajoMaster RPC address.
 # Getting configuration value of http address and rpc address.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Can not run Tajo with non-default $TAJO_CONF_DIR
> ------------------------------------------------
>
>                 Key: TAJO-2184
>                 URL: https://issues.apache.org/jira/browse/TAJO-2184
>             Project: Tajo
>          Issue Type: Bug
>          Components: conf and scripts
>            Reporter: Lee Dongjin
>            Assignee: Lee Dongjin
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> When running start-tajo with non-default TAJO_CONF_DIR, it fails to start workers; More
precisely, it tries to start workers with default TAJO_CONF_DIR (=TAJO_HOME/conf) and fails.
> The missing of \-\-conf parameter in start-tajo.sh causes this problem. For reference,
I hereby attach [the similar shell code from Hadoop project|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/bin/start-all.sh]
- you can see '--conf' is configured here, to run workers via SSH.
> This update gives any significant improvements on performance or user convenience yet,
it will greatly help the users who try to update Tajo version with legacy configurations or
who tries debugging Tajo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message