tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-2185) Eliminate protoc binary dependency
Date Mon, 04 Dec 2017 00:02:00 GMT

    [ https://issues.apache.org/jira/browse/TAJO-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276164#comment-16276164
] 

ASF GitHub Bot commented on TAJO-2185:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1052#discussion_r154541970
  
    --- Diff: tajo-storage/tajo-storage-hbase/pom.xml ---
    @@ -112,26 +112,28 @@
             </executions>
           </plugin>
           <plugin>
    -        <groupId>org.codehaus.mojo</groupId>
    -        <artifactId>exec-maven-plugin</artifactId>
    -        <version>1.2</version>
    +        <groupId>com.github.os72</groupId>
    +        <artifactId>protoc-jar-maven-plugin</artifactId>
    +        <version>3.5.0</version>
             <executions>
               <execution>
    -            <id>generate-sources</id>
                 <phase>generate-sources</phase>
    -            <configuration>
    -              <executable>protoc</executable>
    -              <arguments>
    -                <argument>-Isrc/main/proto/</argument>
    -                <argument>--proto_path=../../tajo-common/src/main/proto</argument>
    -                <argument>--proto_path=../../tajo-catalog/tajo-catalog-common/src/main/proto</argument>
    -                <argument>--java_out=target/generated-sources/proto</argument>
    -                <argument>src/main/proto/StorageFragmentProtos.proto</argument>
    -              </arguments>
    -            </configuration>
                 <goals>
    -              <goal>exec</goal>
    +              <goal>run</goal>
                 </goals>
    +            <configuration>
    +              <protocVersion>2.5.0</protocVersion>
    +              <includeStdTypes>true</includeStdTypes>
    +              <inputDirectories>
    +                <include>src/main/proto/</include>
    +              </inputDirectories>
    +              <includeDirectories>
    +                <includeDirectory>../../tajo-common/src/main/proto</includeDirectory>
    +                <includeDirectory>../../tajo-catalog/tajo-catalog-common/src/main/proto</includeDirectory>
    +                <includeDirectory>../../tajo-core/src/main/proto</includeDirectory>
    --- End diff --
    
    This new directory should be included?


> Eliminate protoc binary dependency
> ----------------------------------
>
>                 Key: TAJO-2185
>                 URL: https://issues.apache.org/jira/browse/TAJO-2185
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 0.11.3
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> Building Tajo project depends on {{protoc}} binary installed on a local machine. It is
very inconvenient because users must install protoc in their local machine. It would be great
if we eliminate this dependency. This patch uses \[1\] to replace the dependency of local
binary by protoc-jar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message