tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinossy <...@git.apache.org>
Subject [GitHub] tajo pull request #1045: TAJO-2170: Disable unsetting timezone property
Date Sun, 28 Aug 2016 07:04:15 GMT
Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1045#discussion_r76527387
  
    --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
    @@ -1110,12 +1113,20 @@ private void setProperties(final int tableId, final KeyValueSetProto
properties)
         }
       }
     
    -  private void unsetProperties(final int tableId, final PrimitiveProtos.StringListProto
propertyKeys) {
    +  private void unsetProperties(final int tableId, final PrimitiveProtos.StringListProto
propertyKeys)
    +      throws UnremovableTablePropertyException {
         final String deleteSql = "DELETE FROM " + TB_OPTIONS + " WHERE TID=? AND KEY_=?";
     
         Connection conn;
         PreparedStatement pstmt = null;
     
    +	  Set<String> keys = Sets.newHashSet(propertyKeys.getValuesList());
    --- End diff --
    
    Please fix indentation in this code block
    https://cwiki.apache.org/confluence/display/TAJO/Code+Style
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message