Return-Path: X-Original-To: apmail-tajo-issues-archive@minotaur.apache.org Delivered-To: apmail-tajo-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F40B0180E5 for ; Tue, 27 Oct 2015 13:12:40 +0000 (UTC) Received: (qmail 74985 invoked by uid 500); 27 Oct 2015 13:12:40 -0000 Delivered-To: apmail-tajo-issues-archive@tajo.apache.org Received: (qmail 74933 invoked by uid 500); 27 Oct 2015 13:12:39 -0000 Mailing-List: contact issues-help@tajo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.apache.org Delivered-To: mailing list issues@tajo.apache.org Received: (qmail 74924 invoked by uid 99); 27 Oct 2015 13:12:39 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 13:12:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D0D88C80F8 for ; Tue, 27 Oct 2015 13:12:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1 X-Spam-Level: * X-Spam-Status: No, score=1 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xJDH-cZaQR_g for ; Tue, 27 Oct 2015 13:12:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 531CF439E9 for ; Tue, 27 Oct 2015 13:12:28 +0000 (UTC) Received: (qmail 74860 invoked by uid 99); 27 Oct 2015 13:12:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 13:12:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A95A32C033A for ; Tue, 27 Oct 2015 13:12:27 +0000 (UTC) Date: Tue, 27 Oct 2015 13:12:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAJO-1877) Adopt try-resource statement to AbstractDBStore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TAJO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976341#comment-14976341 ] ASF GitHub Bot commented on TAJO-1877: -------------------------------------- Github user jihoonson commented on the pull request: https://github.com/apache/tajo/pull/835#issuecomment-151490244 +1 I verified this patch with 'mvn install'. I'll commit soon. > Adopt try-resource statement to AbstractDBStore > ----------------------------------------------- > > Key: TAJO-1877 > URL: https://issues.apache.org/jira/browse/TAJO-1877 > Project: Tajo > Issue Type: Sub-task > Components: Catalog > Reporter: Hyunsik Choi > Assignee: Dongkyu Hwangbo > Labels: newbie > > See https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html. JDK 7 introduced try-resource statement for better resource allocation and deallocation. We can also adopt this feature to AbstractDBStore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)