tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-1461) Follow Protocol Buffer Style Guide
Date Sat, 03 Oct 2015 18:47:26 GMT

    [ https://issues.apache.org/jira/browse/TAJO-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942412#comment-14942412
] 

Hudson commented on TAJO-1461:
------------------------------

FAILURE: Integrated in Tajo-master-CODEGEN-build #548 (See [https://builds.apache.org/job/Tajo-master-CODEGEN-build/548/])
TAJO-1461: Follow Protocol Buffer Style Guide. (Contributed by David (hyunsik: rev 94197c38a5d2bf053f5bebcae4c524e8aa1b552e)
* tajo-common/src/main/proto/PrimitiveProtos.proto
* tajo-client/src/main/proto/ClientProtos.proto
* tajo-common/src/main/proto/TajoIdProtos.proto
* tajo-client/src/main/proto/TajoMasterClientProtocol.proto
* tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
* CHANGES
* tajo-core/src/main/java/org/apache/tajo/master/QueryInfo.java
* tajo-common/src/main/proto/tajo_protos.proto
* tajo-storage/tajo-storage-hdfs/src/main/proto/StorageFragmentProtos.proto
* tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto
* tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
* tajo-core/src/main/proto/InternalTypes.proto
* tajo-storage/tajo-storage-hbase/src/main/proto/StorageFragmentProtos.proto
* tajo-storage/tajo-storage-common/src/main/proto/IndexProtos.proto
* tajo-core/src/main/proto/ResourceProtos.proto
* tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/function/FunctionInvocation.java
* tajo-core/src/main/proto/TajoWorkerProtocol.proto


> Follow Protocol Buffer Style Guide
> ----------------------------------
>
>                 Key: TAJO-1461
>                 URL: https://issues.apache.org/jira/browse/TAJO-1461
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: David Chen
>            Assignee: David Chen
>            Priority: Minor
>             Fix For: 0.12.0
>
>         Attachments: TAJO-1461.0.patch, TAJO-1461.1.patch
>
>
> Similar to HBASE-8915, many of Tajo's Protocol Buffer definitions follow Java conventions
(i.e. {{camelCase}} field names) rather than the convention described in the Protocol Buffers
Style Guide: https://developers.google.com/protocol-buffers/docs/style
> Since we have been discussing improving portability of Tajo's service interfaces (TAJO-1331,
TAJO-1458), it would be good to conform to the Protocol Buffers Style Guide.
> For the most part, this is not a difficult change and for the most part would not result
in much change in the generated Java code since the proto compiler will automatically convert
{{field_name}} to {{getFieldName}} for the generated Java classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message