tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jihoonson <...@git.apache.org>
Subject [GitHub] tajo pull request: TAJO-1877: Adopt try-resource statement to Abst...
Date Fri, 23 Oct 2015 04:28:23 GMT
Github user jihoonson commented on a diff in the pull request:

    --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
    @@ -2640,13 +2480,12 @@ public void addPartitions(String databaseName, String tableName,
       public void createIndex(final IndexDescProto proto)
           throws UndefinedDatabaseException, UndefinedTableException, DuplicateIndexException
    -    Connection conn = null;
         PreparedStatement pstmt = null;
         final String databaseName = proto.getTableIdentifier().getDatabaseName();
         final String tableName = CatalogUtil.extractSimpleName(proto.getTableIdentifier().getTableName());
    -    try {
    +    try (Connection conn = getConnection()) {
    --- End diff --
    Why do you close the connection here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message