tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jihoonson <...@git.apache.org>
Subject [GitHub] tajo pull request: TAJO-1877: Adopt try-resource statement to Abst...
Date Wed, 21 Oct 2015 01:33:11 GMT
Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/808#discussion_r42575224
  
    --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
    @@ -249,18 +246,12 @@ private int getSchemaVersion() {
           LOG.debug(sql.toString());
         }
     
    -    try {
    -      conn = getConnection();
    -      pstmt = conn.prepareStatement(sql);
    -      result = pstmt.executeQuery();
    -
    +    try (ResultSet result = getConnection().prepareStatement(sql).executeQuery()) {
    --- End diff --
    
    PreparedStatement is not closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message