tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-1670) Refactor client errors and exceptions
Date Mon, 20 Jul 2015 00:37:04 GMT

    [ https://issues.apache.org/jira/browse/TAJO-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632999#comment-14632999
] 

ASF GitHub Bot commented on TAJO-1670:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/621#discussion_r34964610
  
    --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogExceptionUtil.java
---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.catalog.exception;
    +
    +import org.apache.tajo.common.TajoDataTypes;
    +import org.apache.tajo.error.Errors;
    +import org.apache.tajo.error.Errors.ResultCode;
    +import org.apache.tajo.function.FunctionUtil;
    +
    +import java.util.Collection;
    +
    +public class CatalogExceptionUtil {
    --- End diff --
    
    Right. I mean, every method in this class creates an exception, but it's difficult to
guess from its name. 
    Its usage is primarily found in the classes of the same package. So, many parts call them
via just their method name without the class name. I think it reduces the readability. 
    What do you think? 


> Refactor client errors and exceptions
> -------------------------------------
>
>                 Key: TAJO-1670
>                 URL: https://issues.apache.org/jira/browse/TAJO-1670
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Java Client, TajoMaster, Worker
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> The main objective is to refactor the error and exception system in client side and its
connected parts like TajoMaster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message