tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-1670) Refactor client errors and exceptions
Date Sun, 19 Jul 2015 23:34:04 GMT

    [ https://issues.apache.org/jira/browse/TAJO-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632972#comment-14632972
] 

ASF GitHub Bot commented on TAJO-1670:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/621#discussion_r34963737
  
    --- Diff: tajo-common/src/main/proto/errors.proto ---
    @@ -0,0 +1,327 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package tajo.error;
    +option java_package = "org.apache.tajo.error";
    +
    +import "stacktrace.proto";
    +
    +// Unstable - this is still evolving.
    +
    +enum ResultCode {
    +  // Class
    +  // 00 - Successful Completion
    +  OK                            = 0;
    +
    +  WARNING                       = 100; // Warning
    +
    +  // General Errors
    +  INTERNAL_ERROR                = 201; // Error caused by internal bugs (See also TajoInternalException.java)
    +  NOT_IMPLEMENTED               = 202; // Planned, but not implemented yet.
    +  FEATURE_NOT_SUPPORTED         = 203; // SQLState: 0A000 - Unsupported feature (usually
for unreasonable feature)
    +  INVALID_RPC_CALL              = 204; // When invalid RPC call is invoked (e.g., wrong
message and absent fields)
    +
    +  // Query Management and Scheduler
    +  NO_SUCH_QUERYID               = 300; // No query id in TajoMaster
    +  NO_DATA                       = 301; // No data due to query fail or error
    +  INCOMPLETE_QUERY              = 302; // It occurs when a client requests something
of a completed query.
    +
    +  // Session
    +  INVALID_SESSION               = 401; // Session already was invalid
    +  NO_SUCH_SESSION_VARIABLE      = 402; // Session variable not found
    +  INVALID_SESSION_VARIABLE      = 403; // Session variable is invalid (type mismatch
or out of range)
    +
    +  // Data Exception (SQLState Class - 22)
    +  DIVISION_BY_ZERO              = 451; // SQLState: 22012 - Division by zero
    +
    +
    +  // Section: Class 42 - Syntax Error or Access Rule Violation
    +  SYNTAX_ERROR_OR_ACCESS_RULE_VIOLATION = 601; // SQLState: 42000
    +  SYNTAX_ERROR                          = 602; // SQLState: 42601
    +  INSUFFICIENT_PRIVILEGE                = 603; // SQLState: 42501
    +
    +  UNDEFINED_TABLESPACE                  = 500; // ?
    --- End diff --
    
    I agreed.


> Refactor client errors and exceptions
> -------------------------------------
>
>                 Key: TAJO-1670
>                 URL: https://issues.apache.org/jira/browse/TAJO-1670
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Java Client, TajoMaster, Worker
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> The main objective is to refactor the error and exception system in client side and its
connected parts like TajoMaster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message