tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-1670) Refactor client errors and exceptions
Date Sun, 19 Jul 2015 23:29:04 GMT

    [ https://issues.apache.org/jira/browse/TAJO-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632961#comment-14632961
] 

ASF GitHub Bot commented on TAJO-1670:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/621#discussion_r34963650
  
    --- Diff: tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto ---
    @@ -24,53 +24,128 @@ option java_generate_equals_and_hash = true;
     import "CatalogProtos.proto";
     import "PrimitiveProtos.proto";
     
    +message GetTablespacesResponse {
    +  required ReturnState state = 1;
    +  repeated TablespaceProto tablespace = 2;
    +}
    +
    +message GetTablespaceResponse {
    +  required ReturnState state = 1;
    +  optional TablespaceProto tablespace = 2;
    +}
    +
    +message GetDatabasesResponse {
    +  required ReturnState state = 1;
    +  repeated DatabaseProto database = 2;
    +}
    +
    +message TableDescResponse {
    +  required ReturnState state = 1;
    +  optional TableDescProto table = 2;
    +}
    +
    +message GetTablesResponse {
    +  required ReturnState state = 1;
    +  repeated TableDescriptorProto table = 2;
    +}
    +
    +message FunctionDescResponse {
    --- End diff --
    
    My intension was to merge it into FunctionResponse in ClientProtos.proto because duplicate
proto type is used in multiple places. But, I finished the merge yet. I'll merge them in this
patch.


> Refactor client errors and exceptions
> -------------------------------------
>
>                 Key: TAJO-1670
>                 URL: https://issues.apache.org/jira/browse/TAJO-1670
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Java Client, TajoMaster, Worker
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> The main objective is to refactor the error and exception system in client side and its
connected parts like TajoMaster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message