tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hyunsik <...@git.apache.org>
Subject [GitHub] tajo pull request: TAJO-1670: Refactor client errors and exception...
Date Sun, 19 Jul 2015 23:24:04 GMT
Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/621#discussion_r34963614
  
    --- Diff: tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto ---
    @@ -24,53 +24,128 @@ option java_generate_equals_and_hash = true;
     import "CatalogProtos.proto";
     import "PrimitiveProtos.proto";
     
    +message GetTablespacesResponse {
    +  required ReturnState state = 1;
    +  repeated TablespaceProto tablespace = 2;
    +}
    +
    +message GetTablespaceResponse {
    +  required ReturnState state = 1;
    +  optional TablespaceProto tablespace = 2;
    +}
    +
    +message GetDatabasesResponse {
    +  required ReturnState state = 1;
    +  repeated DatabaseProto database = 2;
    +}
    +
    +message TableDescResponse {
    --- End diff --
    
    I agreed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message