tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinossy <...@git.apache.org>
Subject [GitHub] tajo pull request: TAJO-1321: Cli prints wrong response time.
Date Mon, 02 Feb 2015 05:07:19 GMT
Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/369#discussion_r23907071
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
---
    @@ -428,9 +426,7 @@ public GetQueryListResponse getFinishedQueryList(RpcController controller,
GetQu
               infoBuilder.setState(queryInfo.getQueryState());
               infoBuilder.setQuery(queryInfo.getSql());
               infoBuilder.setStartTime(queryInfo.getStartTime());
    -          long endTime = (queryInfo.getFinishTime() == 0) ?
    -              System.currentTimeMillis() : queryInfo.getFinishTime();
    -          infoBuilder.setFinishTime(endTime);
    +          infoBuilder.setFinishTime(System.currentTimeMillis());
    --- End diff --
    
    It seems like last request time..
    I suggest that the {{isFinishState}} branch in {{QueryInProgress.hearbeart}} sets the
finish time



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message