Mailing-List: contact issues-help@tajo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tajo.apache.org
Date: Fri, 4 Apr 2014 17:30:17 +0000 (UTC)
From: "Tajo QA (JIRA)" <jira@apache.org>
To: issues@tajo.incubator.apache.org
Message-ID: <JIRA.12671064.1380334206937.65360.1396632617306@arcas>
In-Reply-To: <JIRA.12671064.1380334206937@arcas>
References: <JIRA.12671064.1380334206937@arcas>
Subject: [jira] [Commented] (TAJO-215) Catalog should allow compatible types
 when finding functions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TAJO-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960159#comment-13960159 ] 

Tajo QA commented on TAJO-215:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12638720/TAJO-215.Henrick.02.patch.txt
  against master revision bbee120.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in tajo-catalog/tajo-catalog-server.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/307//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/307//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/307//console

This message is automatically generated.

> Catalog should allow compatible types when finding functions
> ------------------------------------------------------------
>
>                 Key: TAJO-215
>                 URL: https://issues.apache.org/jira/browse/TAJO-215
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: catalog, function/udf
>    Affects Versions: 0.8-incubating, 1.0-incubating
>            Reporter: Hyunsik Choi
>            Assignee: Alvin Henrick
>            Priority: Critical
>              Labels: patch
>             Fix For: 0.8-incubating, 1.0-incubating
>
>         Attachments: TAJO-215.Henrick.01.patch.txt, TAJO-215.Henrick.02.patch.txt
>
>
> Current catalog is strong typed. Given a find request, it only can search for a certain function with the same argument types. However, in many cases, catalog should find functions with compatible parameter types.


--
This message was sent by Atlassian JIRA
(v6.2#6252)