tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Chen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAJO-711) Add Avro storage support
Date Thu, 17 Apr 2014 09:26:15 GMT

    [ https://issues.apache.org/jira/browse/TAJO-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972651#comment-13972651
] 

David Chen edited comment on TAJO-711 at 4/17/14 9:26 AM:
----------------------------------------------------------

Thanks for your detailed review and for committing this patch!

I think I am checking whether {{dataFileReader}} is null in {{AvroScanner}} but I do see that
I am not making that check in {{AvroAppender}}. It seems that it is also possible for {{FileAppender}}
to be closed without calling {{init}}, in which case {{close}} will still need to check whether
the member variables it uses are null. If that is the case, then I can go ahead and open a
separate ticket and make that change, which would be a trivial change.

Also, thanks for going over your idea for schema evolution for tables, Hyunsik. I think your
idea is very interesting. I would like think about it some more and then get back to you.


was (Author: davidzchen):
Thanks for your detailed review and for committing this patch!

I think I am checking whether {{dataFileReader}} is null in {{AvroScanner}} but I do see that
I am not making that check in {{AvroAppender}}. It seems that it is also possible for {{FileAppender}}
to be closed without calling {{init}}, in which case {{close}} will still need to check whether
the member variables it uses are null. If that is the case, then I can go ahead and open a
separate ticket and make that change, which would be a trivial change.

> Add Avro storage support
> ------------------------
>
>                 Key: TAJO-711
>                 URL: https://issues.apache.org/jira/browse/TAJO-711
>             Project: Tajo
>          Issue Type: New Feature
>            Reporter: David Chen
>            Assignee: David Chen
>             Fix For: 0.8, 0.9
>
>         Attachments: TAJO-711.patch, TAJO-711.patch, TAJO-711_140415_rebased.patch, TAJO-711_20140413_20:36:40.patch,
TAJO-711_20140413_21:00:34.patch, TAJO-711_20140413_21:46:27.patch, TAJO-711_20140414_11:07:13.patch,
TAJO-711_20140415_11:13:43.patch
>
>
> Add {{FileScanner}} and {{FileAppender}} for reading from and writing to Avro.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message